Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Pack: Custom fonts, colours overridden in the preview #52

Closed
laurelfulford opened this issue Jun 5, 2019 · 0 comments · Fixed by #55
Closed

Style Pack: Custom fonts, colours overridden in the preview #52

laurelfulford opened this issue Jun 5, 2019 · 0 comments · Fixed by #55
Assignees
Labels
[Type] Bug Incorrect behavior or functionality

Comments

@laurelfulford
Copy link
Contributor

laurelfulford commented Jun 5, 2019

In the preview, if the styles define different fonts or colours, they override the custom fonts and colours in the Customizer preview.

This is because, in the preview, the style pack styles are enqueued via JavaScript, and at the very end of the header. Any styles that come before it are overridden.

I'm not totally convinced we need to include colours/fonts in the style packs, but this would be a nice thing to fix.

Steps to reproduce:

  1. Navigate to Customizer > Style Packs, and pick Style Pack 1.
  2. Navigate to Typography, and set up a custom typeface.
  3. Note it's not previewing.
  4. Navigate to front end; note the style pack and typeface is correct.
  5. Navigate back to the customizer - the font will not be wrong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Incorrect behavior or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant