Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lodestar: Safari 10.1.1 - Gap appears beneath embedded videos on the front page #20

Closed
laurelfulford opened this issue Feb 24, 2018 · 2 comments
Labels
Support [Type] Bug Something isn't working
Milestone

Comments

@laurelfulford
Copy link
Contributor

This issue was originally reported by @dcoleonline in 4698-wpcom-themes:

Steps to replicate

  1. Set up a front page panel that uses two columns. Add this text to the editor of the panel page:
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque a interdum nisl, non hendrerit elit. Orci varius natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Donec vestibulum, lacus et cursus vestibulum, neque nisl fermentum purus, ut interdum ligula felis blandit dui. Duis placerat fermentum tristique. Nullam rhoncus libero id sollicitudin sollicitudin. In congue placerat auctor. Etiam porttitor justo libero, in porta turpis porta eu. Duis mattis ullamcorper tellus ullamcorper vulputate. Vivamus eget velit pretium, ultricies mi a, efficitur ex. Maecenas id viverra neque. Ut ut auctor urna. Cras aliquam commodo quam. Sed sollicitudin tempor semper. Aliquam faucibus malesuada mi vel varius.

Vestibulum a nulla sed ante vestibulum tincidunt in a turpis. Praesent pulvinar elit justo, ut dignissim nulla tincidunt sit amet. Quisque ac volutpat dolor. Sed a massa purus. Ut at massa felis. Nulla dapibus fringilla lorem eget rutrum. Nullam at ligula pretium, blandit velit a, euismod metus. Nunc imperdiet nibh risus, viverra malesuada quam ultricies sit amet. Duis dictum elit sit amet sodales porttitor.

https://www.youtube.com/watch?v=oFgIBZO_T9k
  1. Notice that there is a gap beneath the content that should not appear. I tested this with a Vimeo embed as well, and it looks like the div.jetpack-video-wrapper element is being positioned somewhere other than where the video is displayed. Here is a screenshot to illustrate this:

This is only happening in Safari and can't be reproduced in Chrome or Firefox. It still happens in v11.0.2, and "fixes" itself when you resize the browser window. It doesn't happen on every page load.

@laurelfulford laurelfulford added this to the Lodestar milestone Feb 24, 2018
@sixhours
Copy link
Contributor

sixhours commented Mar 5, 2018

Still reproducing this in 11.0.3. My hunch is it has to do with Jetpack Responsive Videos.

@sixhours
Copy link
Contributor

sixhours commented Mar 6, 2018

@thomasguillot Would you have time to investigate this as part of your work on Responsive Videos this week? Automattic/jetpack#3107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Support [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants