Wrong peerMetadata Sent on Message receive in BroadcastChannel adapter

[justin0mcateer]

https://github.com/automerge/automerge-repo/blob/main/packages/automerge-repo-network-broadcastchannel/src/index.ts#L60

The 'peer-candidate' event is emitted with the peerMetadata of the local Peer, NOT the metadata of the peer we received the message from.

This doesn't make sense and is different from the 'MessageChannel' implementation for example.

[acurrieclark]

Is the senderId in this context not the one received in the message? If so, it is indeed from the new peer.

[justin0mcateer]

senderId is unpacked from the received message in the message handler here:
const { senderId, type } = message

The peerMetadata value is closed over from the call to 'connect' which receives the local peerMetadata from the NetworkSubsystem.

[acurrieclark]

My apologies, I didn’t read your issue correctly at all. You are indeed correct.

Are you in a position to put in a PR?

[acurrieclark]

Fixed by #287