Issue in _get_best_configs of SuccessiveHalving

[sudoRicheek]

SMAC3/smac/intensifier/successive_halving.py

Line 551 in d5d5456

all_keys = [from_keys for _ in configs]

Here all_keys is defined to be of the same length as configs. But here:

SMAC3/smac/intensifier/successive_halving.py

Line 556 in d5d5456

configs.remove(incumbent)

Changes are made to the configs. And here:

SMAC3/smac/intensifier/successive_halving.py

Line 561 in d5d5456

selected_configs = sort_by_crowding_distance(rh, configs, all_keys)[:n_configs]

configs and all_keys are passed to the sort_by_crowding_distance() function, which are required to be of the same length. Am I missing something?

I replaced

SMAC3/smac/intensifier/successive_halving.py

Line 561 in d5d5456

selected_configs = sort_by_crowding_distance(rh, configs, all_keys)[:n_configs]

with

all_keys = [from_keys for _ in selected_configs]
selected_configs = sort_by_crowding_distance(rh, selected_configs, all_keys)[:n_configs] 

and it works fine

[helegraf]

You are correct, thanks for pointing this out!