-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX #17/#26 #32
FIX #17/#26 #32
Conversation
@mlindauer @KEggensperger please review and comment on this. @mlindauer if you agree on this, can you please close #31? |
1 similar comment
Hi, Thanks for the fix. It is working with my examples and the code should be fine. However, I would like to propose a further change (because of efficiency and consistency). Cheers, |
Would it be okay to add this as an issue and solve in a separate PR? |
Yes. |
Ok, I will submit a PR for #35, after this PR was merged. There is no "approve" button in Github? Cheers, |
Correct, there is no "approve" button. We could adapt the scikit-learn policy of changing the PR names like this:
|
approved |
Supersedes #31
Fixes #17 and #26 (together with the latest version of the config space).