Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unassigned variable for marginal plot #85

Closed
janvanrijn opened this issue Mar 29, 2019 · 1 comment
Closed

Unassigned variable for marginal plot #85

janvanrijn opened this issue Mar 29, 2019 · 1 comment

Comments

@janvanrijn
Copy link
Collaborator

Library crashes when invoking the function Visualizer.plot_marginal() with a non-categorical hyperparameter.

Reason:

            # PREPROCESS
            if log_scale is None:
                log_scale = self.cs_params[param].log or (np.diff(grid).std() > 0.000001)

The variable grid has not been assigned/defined. Shall I proceed and remove it for now? What is the exact use of this variable?

@shukon
Copy link
Collaborator

shukon commented Mar 30, 2019

This is probably my fault. Fixed in master by swapping lines.
I think the statement is supposed to be kind of an autodetection whether log-scale would improve plot quality, so I'd leave it in. I changed default behaviour to only do autodetection when log-scale is not set in function parameters (before it just ignored the argument when np.diff(grid).std() > 0.000001, but I think the user should be able to force log-scale if appropriate.)

@shukon shukon closed this as completed in 64d4a45 Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants