Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support python 3.11 #118

Merged
merged 4 commits into from
May 26, 2023
Merged

feat: support python 3.11 #118

merged 4 commits into from
May 26, 2023

Conversation

noandrea
Copy link
Contributor

@noandrea noandrea commented May 8, 2023

Adds support for python 3.11 by updating the autonity.py dependency.

The support is introduced by the upgrade of the web3 dependency to a new major version (6), that brings some breaking changes in method signatures that affects the aut client.

More info here: https://web3py.readthedocs.io/en/stable/v6_migration.html

@noandrea noandrea added the enhancement New feature or request label May 8, 2023
@noandrea noandrea force-pushed the feat/support_python311 branch 14 times, most recently from 6d89d01 to 0ec1f2a Compare May 10, 2023 08:53
@noandrea
Copy link
Contributor Author

there is a very strange error in the CI, I cannot reproduce it anywhere else, also simulating local builds with act.
The error is triggered while checking for dependencies and it is caused by trying to process a corrupted json file/string
https://github.com/autonity/aut/actions/runs/4935051075/jobs/8820868886

@noandrea noandrea force-pushed the feat/support_python311 branch 2 times, most recently from 7502350 to aefcfb6 Compare May 10, 2023 09:55
@cmjc
Copy link
Contributor

cmjc commented May 10, 2023

there is a very strange error in the CI, I cannot reproduce it anywhere else, also simulating local builds with act. The error is triggered while checking for dependencies and it is caused by trying to process a corrupted json file/string https://github.com/autonity/aut/actions/runs/4935051075/jobs/8820868886

The same error message is gotten when using sign-message and the specified key path is wrong - i.e. a file not found or empty/missing value error - rather than 'corrupted'

@noandrea noandrea force-pushed the feat/support_python311 branch 11 times, most recently from afda6d5 to aecceff Compare May 15, 2023 15:58
@noandrea noandrea force-pushed the feat/support_python311 branch 2 times, most recently from 5bc0d7c to 820c152 Compare May 15, 2023 19:39
@noandrea
feat: add new command group 'info' to print relevant autonity contract
5196479 
info

The info group adds a few command that are dedicate to retrieve info
about the autonity contract version used. It also allow to get the path
to the bundled Autonity contract ABI and a link to its source code
@noandrea noandrea marked this pull request as ready for review May 16, 2023 15:44
@noandrea noandrea requested review from rmsams and aiman and removed request for rmsams May 23, 2023 09:48
aiman
aiman approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@aiman aiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I have one UX complaint about going with info.

aut/commands/info.py Outdated Show resolved Hide resolved
@noandrea noandrea requested a review from aiman May 26, 2023 14:58
aiman
aiman approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@aiman aiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@noandrea noandrea merged commit a8cb316 into chore/toolchain May 26, 2023
@noandrea noandrea deleted the feat/support_python311 branch May 26, 2023 15:39
@noandrea noandrea mentioned this pull request Jun 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiman aiman aiman approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noandrea @cmjc @aiman