Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NATS Autopilot Pattern #1

Merged
merged 12 commits into from
Apr 12, 2017
Merged

Add NATS Autopilot Pattern #1

merged 12 commits into from
Apr 12, 2017

Conversation

geek
Copy link
Contributor

@geek geek commented Apr 7, 2017

No description provided.

@sberryman
Copy link

YES!!!! What are the plans for seneca and NATS?

@geek
Copy link
Contributor Author

geek commented Apr 7, 2017

@sberryman no direct plans for seneca-nats, but happy to help if you have plans.

@sberryman
Copy link

@geek, honestly today is the first I've heard of NATS and just got done watching Derek Collison's talk on it. My biggest problem right now with seneca is the req/res assumption; this is also not the right place to be discussing seneca. Either way, it would be interesting to hear how you guys are using NATS. I'm currently using seneca with rabbitmq as the messaging layer. I tried to go with SWIM but it was easier for me to hack together observers on top of rabbitmq topic exchanges.

@geek
Copy link
Contributor Author

geek commented Apr 7, 2017

@sberryman I like the idea of using NATS in the same way you would use rabbitmq with seneca today. Another actor model solution that uses NATS is hemera.

There is a publish only mechanism in seneca, if you don't expect a response... seneca.act({ my: 'message' }); <-- no need for the reply callback.

@sberryman
Copy link

Any idea when you are going to merge this? I ended up getting a few of my old colleagues at Golf Channel on the NATS bandwagon after seeing you post this. I'm also seriously considering a quick attempt at a seneca transport. RMQ is overkill for what I need right now.

@geek
Copy link
Contributor Author

geek commented Apr 12, 2017

@sberryman very cool. I am hoping to have this merged and published tomorrow. How does this PR look to you, anything that you would like to see?

bin/manage.sh Outdated
#!/bin/bash

consulCommand() {
consul-cli --quiet --consul="${CONSUL}:8500" $*
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this getting us that we don't already have from the consul binary in the container?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tgross good catch, I removed in favor of consul members

docker pull $(image):$(tag)

$(DOCKER_CERT_PATH)/key.pub:
ssh-keygen -y -f $(DOCKER_CERT_PATH)/key.pem > $(DOCKER_CERT_PATH)/key.pub
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should try setting up the test job on Jenkins... I'm fairly certain we don't need this here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tgross I will do that, I was hoping to get an initial version out to be able to have the tests fully working

@geek geek self-assigned this Apr 12, 2017
@geek geek added this to the 0.9.6-r0.0.1 milestone Apr 12, 2017
@geek geek merged commit 362378c into master Apr 12, 2017
@geek geek deleted the dev branch April 12, 2017 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants