Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add pull request guidelines #45

Merged
merged 1 commit into from
Mar 9, 2022
Merged

docs: add pull request guidelines #45

merged 1 commit into from
Mar 9, 2022

Conversation

kenji-miyake
Copy link
Contributor

Related: #6

@kenji-miyake kenji-miyake added the type:documentation Creating or refining documentation. label Mar 6, 2022
@github-actions
Copy link

github-actions bot commented Mar 6, 2022

Documentation URL: https://autowarefoundation.github.io/autoware-documentation/pr-45/
Modified URLs:

@kenji-miyake kenji-miyake mentioned this pull request Mar 6, 2022
Open
12 tasks
@isamu-takagi
Copy link
Contributor

How about adding an explanation of what is a small or standard change in PR template?
And It is useful to refer to it from the template.

@kenji-miyake
Copy link
Contributor Author

@isamu-takagi Okay, I'll add a sentence like this: Confirm our contribution guidelines before submitting a pull request.

xmfcx
xmfcx approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read them, haven't used the instructions for committing yet so cannot comment if they are all working.

But they seem good.

@kenji-miyake
Copy link
Contributor Author

Thank you!
I'll merge this after #43.

Base automatically changed from add-contribution-guidelines to add-support-guidelines March 9, 2022 09:18
docs: add pull request guidelines
dedae70 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@kenji-miyake kenji-miyake merged commit 28f28a2 into add-support-guidelines Mar 9, 2022
@kenji-miyake kenji-miyake deleted the add-pull-request-guidelines branch March 9, 2022 09:24
kenji-miyake added a commit that referenced this pull request Mar 9, 2022
@kenji-miyake
docs: add pull request guidelines (#45)
0827c05 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Mar 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmfcx xmfcx xmfcx approved these changes

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r

Assignees
No one assigned
Labels
type:documentation Creating or refining documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kenji-miyake @isamu-takagi @xmfcx