-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(docker-installation): add manual installation steps #62
Conversation
92218f1
to
69f5048
Compare
69f5048
to
61064bc
Compare
@esteve you can check the how it looks in https://autowarefoundation.github.io/autoware-documentation/pr-62/installation/autoware/docker-installation/ |
@xmfcx thanks for writing this up. I only have one comment, but it's mostly that I'd like your opinion, I'm ok with merging this PR as is. |
823cbd9
to
335e1c8
Compare
We can merge this once autowarefoundation/autoware#141 is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 👍
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> can skip if manually installed minor modularize the installation steps Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> Update docs/installation/autoware/docker-installation.md Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
6d98fed
to
c61a669
Compare
I've squashed it because some commits lacked dco sign. Should be ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, no problem!
Signed-off-by: M. Fatih Cırıt mfc@leodrive.ai
Description
This PR adds manual installation steps for the Autoware Docker Installation.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.