Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(docker-installation): add manual installation steps #62

Merged
merged 1 commit into from
Apr 2, 2022

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Mar 25, 2022

Signed-off-by: M. Fatih Cırıt mfc@leodrive.ai

Description

This PR adds manual installation steps for the Autoware Docker Installation.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xmfcx xmfcx changed the title docs(docker-installation): add docker manual installation steps docs(docker-installation): add manual installation steps Mar 25, 2022
@xmfcx xmfcx requested a review from esteve March 25, 2022 20:43
@xmfcx
Copy link
Contributor Author

xmfcx commented Mar 25, 2022

esteve
esteve previously approved these changes Mar 29, 2022
@esteve
Copy link
Contributor

esteve commented Mar 29, 2022

@xmfcx thanks for writing this up. I only have one comment, but it's mostly that I'd like your opinion, I'm ok with merging this PR as is.

@xmfcx
Copy link
Contributor Author

xmfcx commented Mar 31, 2022

We can merge this once autowarefoundation/autoware#141 is merged.

@xmfcx xmfcx enabled auto-merge (squash) April 1, 2022 18:45
kenji-miyake
kenji-miyake previously approved these changes Apr 2, 2022
Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but added a small comment.
image

docs/installation/autoware/docker-installation.md Outdated Show resolved Hide resolved
kenji-miyake
kenji-miyake previously approved these changes Apr 2, 2022
Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>

can skip if manually installed


minor


modularize the installation steps

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>

Update docs/installation/autoware/docker-installation.md

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
@xmfcx
Copy link
Contributor Author

xmfcx commented Apr 2, 2022

I've squashed it because some commits lacked dco sign. Should be ok.

Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, no problem!

@xmfcx xmfcx merged commit fc49095 into main Apr 2, 2022
@xmfcx xmfcx deleted the docker-manual-steps branch April 2, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Creating or refining documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants