Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deploy-docs): add mkdocs-video #202

Merged
merged 2 commits into from
Jan 3, 2023
Merged

feat(deploy-docs): add mkdocs-video #202

merged 2 commits into from
Jan 3, 2023

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Dec 23, 2022

Signed-off-by: M. Fatih Cırıt mfc@leodrive.ai

Description

Let's support embedded videos in our documentation.

https://pypi.org/project/mkdocs-video/

Related to: https://github.com/autowarefoundation/autoware-documentation/pull/281/files#r1056538759

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx
Copy link
Contributor Author

xmfcx commented Dec 23, 2022

As #164 is merged, I got confused.

Should I add a .github/mkdocs-requirements.txt in https://github.com/autowarefoundation/autoware-documentation/ instead? @kenji-miyake

@kenji-miyake
Copy link
Contributor

Should I add a .github/mkdocs-requirements.txt in https://github.com/autowarefoundation/autoware-documentation/ instead? @kenji-miyake

@xmfcx No, adding here is okay because it's for Autoware Documentation.

#164 is for non-Autoware documentation sites. They don't always use the same plugins as Autoware.

@kenji-miyake
Copy link
Contributor

I'll wait for a reply to autowarefoundation/autoware-documentation#281 (comment).
Although the PR was closed, I believe this PR may still be useful.

@xmfcx
Copy link
Contributor Author

xmfcx commented Jan 2, 2023

@kenji-miyake I think it's still better to add this plugin for future videos.

@xmfcx xmfcx enabled auto-merge (squash) January 2, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants