Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(velodyne monitor): fix warning and error threshold of hot temperature #1623

Merged
merged 8 commits into from
Aug 24, 2022

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Aug 18, 2022

Description

  • add config file for each model
  • use VLP-16.param.yaml as default argument
  • update README about config file and operational temperature of each model

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #1623 (1954340) into main (8efee47) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 1954340 differs from pull request most recent head 5f9cdbe. Consider uploading reports for the commit 5f9cdbe to get more accurate results

@@            Coverage Diff             @@
##             main    #1623      +/-   ##
==========================================
- Coverage   10.72%   10.65%   -0.07%     
==========================================
  Files        1103     1108       +5     
  Lines       78408    78772     +364     
  Branches    18653    18640      -13     
==========================================
- Hits         8410     8397      -13     
- Misses      61085    61462     +377     
  Partials     8913     8913              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.64% <ø> (-0.07%) ⬇️ Carriedforward from b6c74ce

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...planning_evaluator/src/planning_evaluator_node.cpp 37.11% <0.00%> (-1.04%) ⬇️
...autoware_utils/test/src/geometry/test_geometry.cpp 42.26% <0.00%> (-0.77%) ⬇️
...utoware_utils/src/geometry/boost_polygon_utils.cpp 83.78% <0.00%> (-0.22%) ⬇️
...include/tier4_autoware_utils/geometry/geometry.hpp 95.52% <0.00%> (-0.10%) ⬇️
...ner/src/scene_module/crosswalk/scene_crosswalk.cpp 0.00% <0.00%> (ø)
common/had_map_utils/src/had_map_query.cpp 0.00% <0.00%> (ø)
common/had_map_utils/src/had_map_visualization.cpp 0.00% <0.00%> (ø)
common/had_map_utils/src/had_map_computation.cpp 0.00% <0.00%> (ø)
common/had_map_utils/src/had_map_conversion.cpp 0.00% <0.00%> (ø)
common/had_map_utils/src/had_map_utils.cpp 0.00% <0.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tkimura4
Copy link
Contributor

tkimura4 commented Aug 23, 2022

@h-ohta
Could you give me links to the documentations you used to determine these values?
(There is no problem even if there are Japanese documents)

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4
Copy link
Contributor

tkimura4 commented Aug 23, 2022

There is no problem with the contents, but the file name below is incorrect, so please correct it.
HDL-32E.param..yaml

@h-ohta
Copy link
Contributor Author

h-ohta commented Aug 24, 2022

Thanks. I'll fix it.

@h-ohta h-ohta force-pushed the fix/velodyne_monitor_temp_hot branch from 1954340 to 5f9cdbe Compare August 24, 2022 02:03
@h-ohta h-ohta enabled auto-merge (squash) August 24, 2022 02:04
@h-ohta h-ohta merged commit df06f93 into autowarefoundation:main Aug 24, 2022
@h-ohta h-ohta deleted the fix/velodyne_monitor_temp_hot branch August 24, 2022 02:14
h-ohta added a commit to tier4/autoware.universe that referenced this pull request Aug 24, 2022
…ture (autowarefoundation#1623)

* fix(velodyne_monitor): fix warning and error threshold of hot temperature

* doc: update README

* doc: fix typo

* doc: update README

* feat: add config file for each model

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* Update Readme.md

* Update Readme.md

* fix: typo

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
h-ohta added a commit to tier4/autoware.universe that referenced this pull request Aug 25, 2022
…ture (1623) (#95)

fix(velodyne monitor): fix warning and error threshold of hot temperature (autowarefoundation#1623)

* fix(velodyne_monitor): fix warning and error threshold of hot temperature

* doc: update README

* doc: fix typo

* doc: update README

* feat: add config file for each model

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* Update Readme.md

* Update Readme.md

* fix: typo

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…ture (autowarefoundation#1623)

* fix(velodyne_monitor): fix warning and error threshold of hot temperature

* doc: update README

* doc: fix typo

* doc: update README

* feat: add config file for each model

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* Update Readme.md

* Update Readme.md

* fix: typo

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ture (autowarefoundation#1623)

* fix(velodyne_monitor): fix warning and error threshold of hot temperature

* doc: update README

* doc: fix typo

* doc: update README

* feat: add config file for each model

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* Update Readme.md

* Update Readme.md

* fix: typo

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ture (autowarefoundation#1623)

* fix(velodyne_monitor): fix warning and error threshold of hot temperature

* doc: update README

* doc: fix typo

* doc: update README

* feat: add config file for each model

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* Update Readme.md

* Update Readme.md

* fix: typo

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
h-ohta added a commit to tier4/autoware.universe that referenced this pull request Oct 13, 2022
…ture (autowarefoundation#1623)

* fix(velodyne_monitor): fix warning and error threshold of hot temperature

* doc: update README

* doc: fix typo

* doc: update README

* feat: add config file for each model

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* Update Readme.md

* Update Readme.md

* fix: typo

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…ture (autowarefoundation#1623)

* fix(velodyne_monitor): fix warning and error threshold of hot temperature

* doc: update README

* doc: fix typo

* doc: update README

* feat: add config file for each model

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* Update Readme.md

* Update Readme.md

* fix: typo

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
s-azumi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 17, 2022
…ture (autowarefoundation#1623)

* fix(velodyne_monitor): fix warning and error threshold of hot temperature

* doc: update README

* doc: fix typo

* doc: update README

* feat: add config file for each model

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* Update Readme.md

* Update Readme.md

* fix: typo

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
h-ohta added a commit to tier4/autoware.universe that referenced this pull request Oct 17, 2022
…oundation#1744 from awf/autoware.universe (#152)

* fix(velodyne monitor): fix warning and error threshold of hot temperature (autowarefoundation#1623)

* fix(velodyne_monitor): fix warning and error threshold of hot temperature

* doc: update README

* doc: fix typo

* doc: update README

* feat: add config file for each model

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* Update Readme.md

* Update Readme.md

* fix: typo

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* fix(velodyne_monitor): add temp_hot_*** to 20 (autowarefoundation#1744)

fix(velodyne_monitor): add 20 to temp_hot_***

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…ture (autowarefoundation#1623)

* fix(velodyne_monitor): fix warning and error threshold of hot temperature

* doc: update README

* doc: fix typo

* doc: update README

* feat: add config file for each model

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* Update Readme.md

* Update Readme.md

* fix: typo

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants