Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tier4_planning_rviz_plugin): apply clang-tidy for drivable_area #1625

Merged

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Aug 18, 2022

Description

  • apply NOLINT for readability-redundant-access-specifiers due to Qt
  • fix below
    • modernize-use-nodiscard
    • llvm-namespace-comment
    • modernize-concat-nested-namespaces
    • readability-make-member-function-const
    • cppcoreguidelines-init-variables
    • readability-convert-member-functions-to-static

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ohta h-ohta force-pushed the refactor/tier4_planning_rviz_drivable branch from 23a016b to fdf7830 Compare August 18, 2022 12:56
@h-ohta h-ohta enabled auto-merge (squash) August 18, 2022 12:57
@h-ohta h-ohta force-pushed the refactor/tier4_planning_rviz_drivable branch from 950f669 to db40c4a Compare August 18, 2022 13:17
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #1625 (db40c4a) into main (ce8f2c3) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1625      +/-   ##
==========================================
- Coverage   10.78%   10.78%   -0.01%     
==========================================
  Files        1109     1109              
  Lines       78377    78379       +2     
  Branches    18555    18555              
==========================================
  Hits         8451     8451              
- Misses      61069    61071       +2     
  Partials     8857     8857              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.76% <ø> (ø) Carriedforward from ce8f2c3

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...planning_rviz_plugin/src/drivable_area/display.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@h-ohta h-ohta merged commit 4be87d9 into autowarefoundation:main Aug 18, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…rea (autowarefoundation#1625)

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…rea (autowarefoundation#1625)

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…rea (autowarefoundation#1625)

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…rea (autowarefoundation#1625)

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
@h-ohta h-ohta deleted the refactor/tier4_planning_rviz_drivable branch October 17, 2022 05:45
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…rea (autowarefoundation#1625)

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants