Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blindspot insert zero index #1674

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Aug 24, 2022

Description

fix blindspot insert duplicate stop point at index zero
note : this is only for hotfix

review procedure
to check this case works fine without dying
image
image

TODO

  • remove this insert point original functions after merging this change
  • replace blindspot util to motion utils

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #1674 (484c71d) into main (df06f93) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1674      +/-   ##
==========================================
- Coverage   10.71%   10.70%   -0.02%     
==========================================
  Files        1103     1103              
  Lines       78404    78491      +87     
  Branches    18648    18727      +79     
==========================================
  Hits         8400     8400              
- Misses      61089    61172      +83     
- Partials     8915     8919       +4     
Flag Coverage Δ *Carryforward flag
differential 4.13% <0.00%> (?)
total 10.69% <0.00%> (ø) Carriedforward from 7ca012b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...city_planner/src/scene_module/blind_spot/scene.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@taikitanaka3
Copy link
Contributor Author

This case is also solved
image

@taikitanaka3 taikitanaka3 enabled auto-merge (squash) August 24, 2022 07:07
@taikitanaka3 taikitanaka3 merged commit 7b94ead into main Aug 24, 2022
@taikitanaka3 taikitanaka3 deleted the fix/blindspot_insert_zero_index branch August 24, 2022 07:33
taikitanaka3 added a commit to tier4/autoware.universe that referenced this pull request Aug 24, 2022
* fix: blindspot insert zero index

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: return index

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
0x126 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 24, 2022
* fix: blindspot insert zero index

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: return index

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
* fix: blindspot insert zero index

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: return index

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
* fix: blindspot insert zero index

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: return index

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
* fix: blindspot insert zero index

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: return index

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
* fix: blindspot insert zero index

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: return index

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
* fix: blindspot insert zero index

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: return index

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants