Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(planning_debug_tools): add accleration calculation #1782

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Sep 5, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

add acceleration calculation for trajectory visualizer

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review September 5, 2022 07:56
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #1782 (78ae1f7) into main (6e739b6) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1782      +/-   ##
==========================================
- Coverage   10.46%   10.38%   -0.08%     
==========================================
  Files        1221     1212       -9     
  Lines       87578    87434     -144     
  Branches    20498    20282     -216     
==========================================
- Hits         9165     9080      -85     
+ Misses      68940    68873      -67     
- Partials     9473     9481       +8     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.37% <0.00%> (-0.08%) ⬇️ Carriedforward from 52a8962

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...clude/planning_debug_tools/trajectory_analyzer.hpp 0.00% <0.00%> (ø)
..._debug_tools/include/planning_debug_tools/util.hpp 0.00% <0.00%> (ø)
...polation/include/interpolation/zero_order_hold.hpp 47.05% <0.00%> (-34.76%) ⬇️
...ocity_planner/src/utilization/path_utilization.cpp 18.91% <0.00%> (-2.30%) ⬇️
control/trajectory_follower/test/test_mpc.cpp 55.68% <0.00%> (-1.14%) ⬇️
...ctory_follower/src/pid_longitudinal_controller.cpp 38.49% <0.00%> (-1.12%) ⬇️
...trajectory_follower/src/mpc_lateral_controller.cpp 34.64% <0.00%> (-0.98%) ⬇️
.../motion_velocity_smoother/src/trajectory_utils.cpp 3.34% <0.00%> (-0.90%) ⬇️
...tion_utils/test/src/trajectory/test_trajectory.cpp 25.62% <0.00%> (-0.64%) ⬇️
...nning/behavior_velocity_planner/test/src/utils.hpp 82.22% <0.00%> (-0.14%) ⬇️
... and 96 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168
Copy link
Contributor Author

@TakaHoribe Code owner's review is required. Give me LGTM!

Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@takayuki5168 takayuki5168 merged commit c1de6c0 into autowarefoundation:main Sep 10, 2022
@takayuki5168 takayuki5168 deleted the feat/acc-calculation-in-trajectory-visualizer branch September 10, 2022 08:12
taikitanaka3 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 14, 2022
taikitanaka3 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 14, 2022
taikitanaka3 added a commit to tier4/autoware.universe that referenced this pull request Sep 14, 2022
* feat: add planning debug tools (#1362)

* add planning_debug_tools and trajectory_analyzer implementation

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* precommit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* change output topic name

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* precommit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* add missing depend

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* ci(pre-commit): autofix

* update

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* move smoother tools to debug_tools

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(planning_debug_tools): add readme and add yaw to analyzer (autowarefoundation#1613)

* feat(planning_debug_tools): add readme and add yaw to analyzer

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: remove verbose

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* update docs

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix precommit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* feat(planning_debug_tools): add accleration calculation (autowarefoundation#1782)

* chore: fix maintainer

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat(planning_debug_tools): add stop reason visualizer (autowarefoundation#1847)

* feat(planning_debug_tools): add stop reason visualizer

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore : minor change

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: pre-commit

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat: add stop reason text

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: add stop text

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* doc : add readme

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* doc: fix indent

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat(tier4_autoware_utils): add time argument in appendMarkerArray (#1415)

* feat(tier4_autoware_utils): add time argument in appendMarkerArray

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add default argument

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants