Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ModelZoo): rework prebuilt assets management #1880

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

ambroise-arm
Copy link
Contributor

@ambroise-arm ambroise-arm commented Sep 15, 2022

Description

ModelZoo artifacts changed from a single archive to one archive per model/backend combination. It allows users to only download needed archives, but prevents keeping the current design.

Change from all models being handled by the "neural_networks_provider" package to models being downloaded by packages that need them.

Leverage the newly added versioning of the prebuilt models.

Related links

Part of #1879

Tests performed

Tested locally by building the TVM packages with --cmake-args -DDOWNLOAD_ARTIFACTS=ON and running the unit tests of those packages.

Notes for reviewers

#1181 needs to be merged first.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@ambroise-arm ambroise-arm changed the title Modelzoo artifacts feat(ModelZoo): rework prebuilt assets management Sep 15, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 10.78% // Head: 10.37% // Decreases project coverage by -0.40% ⚠️

Coverage data is based on head (0bdcf51) compared to base (272f8a2).
Patch has no changes to coverable lines.

❗ Current head 0bdcf51 differs from pull request most recent head 0029108. Consider uploading reports for the commit 0029108 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1880      +/-   ##
==========================================
- Coverage   10.78%   10.37%   -0.41%     
==========================================
  Files        1179     1163      -16     
  Lines       84449    82840    -1609     
  Branches    19795    19287     -508     
==========================================
- Hits         9104     8594     -510     
+ Misses      65853    64976     -877     
+ Partials     9492     9270     -222     
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 10.35% <ø> (-0.41%) ⬇️ Carriedforward from d7565c2

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lude/freespace_planning_algorithms/reeds_shepp.hpp 50.00% <0.00%> (-50.00%) ⬇️
.../freespace_planning_algorithms/src/reeds_shepp.cpp 55.51% <0.00%> (-38.97%) ⬇️
...eespace_planning_algorithms/abstract_algorithm.hpp 44.44% <0.00%> (-25.56%) ⬇️
...lude/behavior_path_planner/turn_signal_decider.hpp 25.00% <0.00%> (-25.00%) ⬇️
...ehicle/raw_vehicle_cmd_converter/src/accel_map.cpp 19.23% <0.00%> (-21.51%) ⬇️
...hicle/raw_vehicle_cmd_converter/src/csv_loader.cpp 53.84% <0.00%> (-16.37%) ⬇️
...ehicle/raw_vehicle_cmd_converter/src/brake_map.cpp 17.85% <0.00%> (-15.48%) ⬇️
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 64.15% <0.00%> (-9.44%) ⬇️
...ace_planning_algorithms/src/abstract_algorithm.cpp 78.16% <0.00%> (-5.54%) ⬇️
common/motion_utils/src/resample/resample.cpp 30.97% <0.00%> (-1.70%) ⬇️
... and 218 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ambroise-arm ambroise-arm marked this pull request as ready for review October 4, 2022 15:07
@xmfcx xmfcx requested a review from angry-crab October 4, 2022 15:42
@angry-crab
Copy link
Contributor

angry-crab commented Oct 12, 2022

@ambroise-arm
Currently, it seems that neural_network_provider is only used by tvm packages while tensorrt packages depend on trtexec_vendor. If we are not going to extend neural_network_provider its usage to cover tensorrt, I think it makes sense to merge neural_network_provider into tvm_utility.

ModelZoo artifacts changed from a single archive to one archive per
model/backend combination. It allows users to only download needed
archives, but prevents keeping the current design.

Change from all models being handled by the "neural_networks_provider"
package to models being downloaded by packages that need them.

Leverage the newly added versioning of the prebuilt models.

Fix the NN check of the "nodes" package.

Issue-Id: SCM-3999
Signed-off-by: Ambroise Vincent <ambroise.vincent@arm.com>
Change-Id: I1df9007f5bf446a8b50e38c4fd98e9e3a8d2550f
@ambroise-arm
Copy link
Contributor Author

I think it makes sense to merge neural_network_provider into tvm_utility.

@angry-crab Done

Copy link
Contributor

@angry-crab angry-crab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angry-crab angry-crab enabled auto-merge (squash) October 19, 2022 07:14
@angry-crab angry-crab merged commit 844d977 into autowarefoundation:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants