Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lidar_apollo_segmentation_tvm, tvm_utility): fixed output dim and pipeline #2185

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

angry-crab
Copy link
Contributor

@angry-crab angry-crab commented Nov 1, 2022

Signed-off-by: Xinyu Wang xinyu.wang@tier4.jp

Description

Resolve #1988
Changed default allocation device according to config. Fixed output data transfer in case of GPU involved.
Reason discussed in the follwing issue.
#1898

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@angry-crab
Copy link
Contributor Author

update bcnn has to be merged before this one.

Copy link
Contributor

@ambroise-arm ambroise-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the update of the model, the unit test of lidar_apollo_segmentaiton_tvm doesn't pass anymore:

TEST(lidar_apollo_segmentation_tvm, runtime_error) { test_segmentation(false, false, true); }

Which needs to become test_segmentation(false, false, false).
The comments won't make much sense then. Maybe you could put the 4 test_segmentation() intensity/constant feature combinations in a single test group.

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 10.55% // Head: 11.08% // Increases project coverage by +0.53% 🎉

Coverage data is based on head (f16041b) compared to base (3d714ac).
Patch has no changes to coverable lines.

❗ Current head f16041b differs from pull request most recent head 328c2c2. Consider uploading reports for the commit 328c2c2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2185      +/-   ##
==========================================
+ Coverage   10.55%   11.08%   +0.53%     
==========================================
  Files        1256     1212      -44     
  Lines       91029    86620    -4409     
  Branches    20790    20847      +57     
==========================================
- Hits         9611     9606       -5     
+ Misses      71260    66852    -4408     
- Partials    10158    10162       +4     
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 11.06% <ø> (+0.53%) ⬆️ Carriedforward from 642f067

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 73.58% <0.00%> (-9.44%) ⬇️
...est_node/include/fake_test_node/fake_test_node.hpp 39.13% <0.00%> (ø)
...or_path_planner/src/scene_module/pull_out/util.cpp 0.00% <0.00%> (ø)
...ity_smoother/src/motion_velocity_smoother_node.cpp 0.00% <0.00%> (ø)
...ity_limiter/src/obstacle_velocity_limiter_node.cpp 0.64% <0.00%> (ø)
...nner/src/scene_module/pull_out/pull_out_module.cpp 0.00% <0.00%> (ø)
...nterline_optimizer/srv/plan_path__type_support.cpp
...ine_optimizer_s.ep.rosidl_typesupport_fastrtps_c.c
...c_centerline_optimizer_s.ep.rosidl_typesupport_c.c
...ptimizer/msg/points_with_lane_id__type_support.cpp
... and 41 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ambroise-arm ambroise-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angry-crab angry-crab enabled auto-merge (squash) November 8, 2022 02:09
@angry-crab
Copy link
Contributor Author

@ambroise-arm It seems that approving from reviewers with write access is required. Would you talk to @mitsudome-r about this? Thanks.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Nov 14, 2022
@angry-crab
Copy link
Contributor Author

@mitsudome-r This PR can be merged.

@xmfcx
Copy link
Contributor

xmfcx commented Nov 15, 2022

@angry-crab can you rebase this PR? Auto-rebase warns of conflicts.

Xinyu Wang and others added 3 commits November 16, 2022 01:18
Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
@angry-crab
Copy link
Contributor Author

@angry-crab can you rebase this PR? Auto-rebase warns of conflicts.

Done!

@xmfcx xmfcx merged commit 7e37a6c into autowarefoundation:main Nov 15, 2022
@angry-crab angry-crab deleted the tvm_apollo_test branch November 15, 2022 23:57
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
… pipeline (autowarefoundation#2185)

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
… pipeline (autowarefoundation#2185)

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
… pipeline (autowarefoundation#2185)

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate lidar_apollo_segmentation_tvm detection quality
3 participants