Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(map_based_prediction): fix too short predicted path #2305

Merged
merged 3 commits into from
Nov 16, 2022

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Nov 16, 2022

Description

In map_based_pridiction, there are cases where the length of predicted_path of objects is extremely short.

https://user-images.githubusercontent.com/59680180/202166907-ccff8a81-b19c-4155-9971-f728806a0c0f.mp4
(arround 0:24)

This is because the search_dist for possiblePaths() is too short to sufficiently explore far lanes.
I fixed this by adding a Frenet length of the current lane to search_dist.

Note: this can cause increase in CPU consumption.

Related links

Tests performed

@ Planning simulator
https://user-images.githubusercontent.com/59680180/202167875-1d594bfb-de97-4a47-80ef-fa0ddc9e1489.mp4
https://user-images.githubusercontent.com/59680180/202167896-532a2378-336e-4f95-8a6b-e35e7ce7ae85.mp4
https://user-images.githubusercontent.com/59680180/202167926-d6334f30-9b57-4072-8e3d-a9502d5022a2.mp4

I also confirmed that the frequency of /perception/object_recognition/objects output by map_based_prediction does not drop significantly.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Nov 16, 2022
@tkimura4
Copy link
Contributor Author

Besides bug fixes, by giving the parameter includeShorterPaths: True to possiblePaths(), I removed redundant processing.

https://github.com/fzi-forschungszentrum-informatik/Lanelet2/blob/master/lanelet2_routing/include/lanelet2_routing/RoutingGraph.h#L55

bool includeShorterPaths{false}; //!< also return paths that do not reach the limits

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 10.50% // Head: 10.49% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (e044a3a) compared to base (bbf26cc).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2305      +/-   ##
==========================================
- Coverage   10.50%   10.49%   -0.02%     
==========================================
  Files        1248     1248              
  Lines       90581    90697     +116     
  Branches    20705    20705              
==========================================
  Hits         9516     9516              
- Misses      70970    71086     +116     
  Partials    10095    10095              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.48% <0.00%> (ø) Carriedforward from bbf26cc

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ternal_cmd_selector/external_cmd_selector_node.cpp 0.00% <0.00%> (ø)
...c/pure_pursuit/pure_pursuit_lateral_controller.cpp 0.00% <0.00%> (ø)
...map_based_prediction/map_based_prediction_node.hpp 0.00% <ø> (ø)
...based_prediction/src/map_based_prediction_node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your corrections! LGTM!

@tkimura4 tkimura4 merged commit 0a56b56 into autowarefoundation:main Nov 16, 2022
@tkimura4 tkimura4 deleted the fix/short_predcited_Path branch November 16, 2022 13:55
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…dation#2305)

* fix(map_based_prediction): fix too short predicted path

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix: remove unused variable

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* remove AddValidPath

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…dation#2305)

* fix(map_based_prediction): fix too short predicted path

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix: remove unused variable

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* remove AddValidPath

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
…dation#2305)

* fix(map_based_prediction): fix too short predicted path

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix: remove unused variable

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* remove AddValidPath

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants