Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_datetime_rviz_plugin): fix datetime plugin #2753

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Jan 26, 2023

Signed-off-by: Takagi, Isamu isamu.takagi@tier4.jp

Description

Fix autowarefoundation/autoware#3173.
If the timer callback is executed before onInitialize function, rviz_ros_node_ will be used without initialization.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Jan 26, 2023
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 12.42% // Head: 11.54% // Decreases project coverage by -0.89% ⚠️

Coverage data is based on head (836d0cb) compared to base (642f172).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2753      +/-   ##
==========================================
- Coverage   12.42%   11.54%   -0.89%     
==========================================
  Files        1212     1309      +97     
  Lines       85681    91359    +5678     
  Branches    24345    24247      -98     
==========================================
- Hits        10648    10549      -99     
- Misses      63916    69769    +5853     
+ Partials    11117    11041      -76     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.54% <0.00%> (-0.89%) ⬇️ Carriedforward from 4ee89d1

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...tetime_rviz_plugin/src/autoware_datetime_panel.cpp 0.00% <0.00%> (ø)
...ty_planner/src/scene_module/intersection/debug.cpp 0.00% <0.00%> (ø)
...c/scene_module/intersection/scene_intersection.cpp 0.00% <0.00%> (ø)
...alization/gyro_odometer/src/gyro_odometer_core.cpp 0.00% <0.00%> (-46.97%) ⬇️
...planning_evaluator/src/planning_evaluator_node.cpp 34.37% <0.00%> (-2.09%) ⬇️
...erception/traffic_light_classifier/src/nodelet.cpp 0.00% <0.00%> (ø)
...alization/gyro_odometer/src/gyro_odometer_node.cpp 0.00% <0.00%> (ø)
...stacle_avoidance_planner/src/utils/debug_utils.cpp 0.00% <0.00%> (ø)
...path_planner/src/scene_module/lane_change/util.cpp 0.00% <0.00%> (ø)
... and 107 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@isamu-takagi isamu-takagi self-assigned this Jan 26, 2023
@taikitanaka3
Copy link
Contributor

@isamu-takagi
What is the blocking to open this PR?

@isamu-takagi
Copy link
Contributor Author

@taikitanaka3
I tried to fix this issue but it didn't work.

@stale
Copy link

stale bot commented Apr 7, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Apr 7, 2023
@isamu-takagi isamu-takagi deleted the fix/tier4-datetime-rviz-plugin branch November 22, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rviz2 failed/crash with additional monitor
3 participants