-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tier4_datetime_rviz_plugin): fix datetime plugin #2753
fix(tier4_datetime_rviz_plugin): fix datetime plugin #2753
Conversation
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Codecov ReportBase: 12.42% // Head: 11.54% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2753 +/- ##
==========================================
- Coverage 12.42% 11.54% -0.89%
==========================================
Files 1212 1309 +97
Lines 85681 91359 +5678
Branches 24345 24247 -98
==========================================
- Hits 10648 10549 -99
- Misses 63916 69769 +5853
+ Partials 11117 11041 -76
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@isamu-takagi |
@taikitanaka3 |
This pull request has been automatically marked as stale because it has not had recent activity. |
Signed-off-by: Takagi, Isamu isamu.takagi@tier4.jp
Description
Fix autowarefoundation/autoware#3173.
If the timer callback is executed before
onInitialize
function,rviz_ros_node_
will be used without initialization.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.