Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(simple_planning_sim): publish sensing interface imu data #2843

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Feb 8, 2023

Description

Add imu publisher in the simple_planning_simulator so that the planning modules using imu info can run.

Related links

Tests performed

Run psim and check if the imu topic is published:

ros2 topic echo /sensing/imu/imu_data

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe requested review from tkimura4 and a team as code owners February 8, 2023 10:59
@github-actions github-actions bot added the component:simulation Virtual environment setups and simulations. (auto-assigned) label Feb 8, 2023
Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901
Copy link
Contributor

@TakaHoribe It works well on PSim

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 11.61% // Head: 11.69% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (8bb8b70) compared to base (2a93ee3).
Patch coverage: 61.53% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2843      +/-   ##
==========================================
+ Coverage   11.61%   11.69%   +0.07%     
==========================================
  Files        1319     1319              
  Lines       92107    92234     +127     
  Branches    24424    24511      +87     
==========================================
+ Hits        10701    10786      +85     
- Misses      70233    70252      +19     
- Partials    11173    11196      +23     
Flag Coverage Δ *Carryforward flag
differential 57.24% <73.68%> (?)
total 11.61% <31.25%> (-0.01%) ⬇️ Carriedforward from d50ce38

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../scene_module/utils/geometric_parallel_parking.cpp 0.00% <0.00%> (ø)
...nning_simulator/simple_planning_simulator_core.hpp 71.42% <ø> (-6.35%) ⬇️
...nning_simulator/simple_planning_simulator_core.cpp 45.17% <76.19%> (+7.75%) ⬆️
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 88.09% <0.00%> (+2.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TakaHoribe TakaHoribe merged commit 95be33e into autowarefoundation:main Feb 10, 2023
@TakaHoribe TakaHoribe deleted the feat/publish-imu-data-simple-sim branch February 10, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:simulation Virtual environment setups and simulations. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants