-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(simple_planning_sim): publish sensing interface imu data #2843
feat(simple_planning_sim): publish sensing interface imu data #2843
Conversation
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@TakaHoribe It works well on PSim |
Codecov ReportBase: 11.61% // Head: 11.69% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2843 +/- ##
==========================================
+ Coverage 11.61% 11.69% +0.07%
==========================================
Files 1319 1319
Lines 92107 92234 +127
Branches 24424 24511 +87
==========================================
+ Hits 10701 10786 +85
- Misses 70233 70252 +19
- Partials 11173 11196 +23
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
...r/simple_planning_simulator/src/simple_planning_simulator/simple_planning_simulator_core.cpp
Outdated
Show resolved
Hide resolved
...r/simple_planning_simulator/src/simple_planning_simulator/simple_planning_simulator_core.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add imu publisher in the
simple_planning_simulator
so that the planning modules using imu info can run.Related links
Tests performed
Run psim and check if the imu topic is published:
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.