Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(image_projection_based_fusion): add trust distance to fusion #2844

Merged

Conversation

kaancolak
Copy link
Contributor

@kaancolak kaancolak commented Feb 8, 2023

Signed-off-by: Kaan Colak kaancolak95@gmail.com

Description

#2659

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kaancolak kaancolak requested review from yukkysaito, yukke42 and a team as code owners February 8, 2023 13:45
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Feb 8, 2023
Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
@kaancolak kaancolak force-pushed the feat/image-projection-based-fusion branch from 64e8db0 to 36a7c12 Compare February 8, 2023 13:46
@kaancolak
Copy link
Contributor Author

Hi @yukkysaito -san , Could you review this PR?

Sorry for the delay, I was working on other tasks.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 11.63% // Head: 11.62% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (893db01) compared to base (95be33e).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2844      +/-   ##
==========================================
- Coverage   11.63%   11.62%   -0.01%     
==========================================
  Files        1321     1321              
  Lines       92202    92154      -48     
  Branches    24472    24421      -51     
==========================================
- Hits        10727    10714      -13     
+ Misses      70290    70258      -32     
+ Partials    11185    11182       -3     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.63% <0.00%> (-0.01%) ⬇️ Carriedforward from 3974c82

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ction_based_fusion/src/roi_cluster_fusion/node.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <ø> (ø)
planning/behavior_path_planner/src/utilities.cpp 8.07% <ø> (+0.13%) ⬆️
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 85.71% <0.00%> (-2.39%) ⬇️
...nning_simulator/simple_planning_simulator_core.cpp 37.42% <0.00%> (-1.96%) ⬇️
...rol/operation_mode_transition_manager/src/node.cpp 0.00% <0.00%> (ø)
...ol/operation_mode_transition_manager/src/state.cpp 0.00% <0.00%> (ø)
...path_planner/src/scene_module/lane_change/util.cpp 0.00% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
@kaancolak kaancolak requested a review from miursh February 9, 2023 09:10
@kaancolak kaancolak self-assigned this Feb 9, 2023
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaancolak kaancolak changed the title feat(image_projection_based_fusion): add thrust distance to fusion feat(image_projection_based_fusion): add trust distance to fusion Feb 9, 2023
Copy link
Contributor

@yukke42 yukke42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaancolak kaancolak merged commit 93fbdb9 into autowarefoundation:main Feb 11, 2023
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Mar 15, 2023
…towarefoundation#2844)

* feat(image_projection_based_fusion): add thrust distance to fusion

Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>

* feat(image_projection_based_fusion): fix typo

Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>

---------

Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Mar 15, 2023
* fix(roi_cluster_fusion): add unknown-object removal (autowarefoundation#2701)

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* feat(image_projection_based_fusion): add trust distance to fusion (autowarefoundation#2844)

* feat(image_projection_based_fusion): add thrust distance to fusion

Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>

* feat(image_projection_based_fusion): fix typo

Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>

---------

Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
Co-authored-by: badai nguyen <94814556+badai-nguyen@users.noreply.github.com>
Co-authored-by: Kaan Çolak <kaancolak95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants