-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(image_projection_based_fusion): add trust distance to fusion #2844
feat(image_projection_based_fusion): add trust distance to fusion #2844
Conversation
Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
64e8db0
to
36a7c12
Compare
Hi @yukkysaito -san , Could you review this PR? Sorry for the delay, I was working on other tasks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportBase: 11.63% // Head: 11.62% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2844 +/- ##
==========================================
- Coverage 11.63% 11.62% -0.01%
==========================================
Files 1321 1321
Lines 92202 92154 -48
Branches 24472 24421 -51
==========================================
- Hits 10727 10714 -13
+ Misses 70290 70258 -32
+ Partials 11185 11182 -3
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
...ge_projection_based_fusion/include/image_projection_based_fusion/roi_cluster_fusion/node.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…towarefoundation#2844) * feat(image_projection_based_fusion): add thrust distance to fusion Signed-off-by: Kaan Çolak <kaancolak95@gmail.com> * feat(image_projection_based_fusion): fix typo Signed-off-by: Kaan Çolak <kaancolak95@gmail.com> --------- Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
* fix(roi_cluster_fusion): add unknown-object removal (autowarefoundation#2701) Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * feat(image_projection_based_fusion): add trust distance to fusion (autowarefoundation#2844) * feat(image_projection_based_fusion): add thrust distance to fusion Signed-off-by: Kaan Çolak <kaancolak95@gmail.com> * feat(image_projection_based_fusion): fix typo Signed-off-by: Kaan Çolak <kaancolak95@gmail.com> --------- Signed-off-by: Kaan Çolak <kaancolak95@gmail.com> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: Kaan Çolak <kaancolak95@gmail.com> Co-authored-by: badai nguyen <94814556+badai-nguyen@users.noreply.github.com> Co-authored-by: Kaan Çolak <kaancolak95@gmail.com>
Signed-off-by: Kaan Colak kaancolak95@gmail.com
Description
#2659
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.