Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix geometric parallel parking guard #2857

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Feb 10, 2023

Signed-off-by: kosuke55 kosuke.tnp@gmail.com

Description

fix geometric parallel parking guard

Related links

tier iv internal link

Tests performed

psim

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 12.39% // Head: 11.62% // Decreases project coverage by -0.78% ⚠️

Coverage data is based on head (8a43f5a) compared to base (a7f20aa).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2857      +/-   ##
==========================================
- Coverage   12.39%   11.62%   -0.78%     
==========================================
  Files        1221     1321     +100     
  Lines       86413    92175    +5762     
  Branches    24467    24467              
==========================================
+ Hits        10712    10713       +1     
- Misses      64520    70282    +5762     
+ Partials    11181    11180       -1     
Flag Coverage Δ *Carryforward flag
differential 4.67% <0.00%> (?)
total 11.62% <ø> (-0.78%) ⬇️ Carriedforward from 9c632a5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../scene_module/utils/geometric_parallel_parking.cpp 0.00% <0.00%> (ø)
...erception/traffic_light_classifier/src/nodelet.cpp 0.00% <0.00%> (ø)
...rol/operation_mode_transition_manager/src/node.cpp 0.00% <0.00%> (ø)
...ol/operation_mode_transition_manager/src/state.cpp 0.00% <0.00%> (ø)
...on/lidar_centerpoint/src/single_inference_node.cpp 0.00% <0.00%> (ø)
...ar_apollo_instance_segmentation/lib/src/TrtNet.cpp 0.00% <0.00%> (ø)
...enterpoint/postprocess/non_maximum_suppression.hpp 0.00% <0.00%> (ø)
...apollo_instance_segmentation/feature_generator.hpp 0.00% <0.00%> (ø)
...dor/_deps/tensorrt-src/samples/common/safeCommon.h 0.00% <0.00%> (ø)
...ed_fusion/pointpainting_fusion/voxel_generator.hpp 0.00% <0.00%> (ø)
... and 95 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55 kosuke55 merged commit d034c09 into autowarefoundation:main Feb 10, 2023
@kosuke55 kosuke55 deleted the fix/geometric_parallel_parking_guard branch February 10, 2023 09:57
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Feb 10, 2023
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants