Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tier4_planning_rviz_plugin): create abstract class for footprint #2870

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Feb 11, 2023

Description

Footprint for path with lane id, path, trajectory is almost same implementation.
Therefore, I created an abstract class for them.

The only difference among the footprints is that path with lane id has lane_id visualization.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Feb 11, 2023
@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Base: 11.63% // Head: 11.62% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (f6ec735) compared to base (d30616f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2870      +/-   ##
==========================================
- Coverage   11.63%   11.62%   -0.01%     
==========================================
  Files        1321     1322       +1     
  Lines       92199    92265      +66     
  Branches    24471    24471              
==========================================
  Hits        10726    10726              
- Misses      70287    70353      +66     
  Partials    11186    11186              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.64% <ø> (+0.01%) ⬆️ Carriedforward from b3e9014

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ing_rviz_plugin/include/path_footprint/display.hpp 0.00% <0.00%> (ø)
...viz_plugin/include/path_footprint/display_base.hpp 0.00% <0.00%> (ø)
...lanning_rviz_plugin/src/path_footprint/display.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…rint

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the refactor/tier4-planning-rviz-plugin branch from 86b0a07 to 01d490e Compare February 11, 2023 07:10
@takayuki5168 takayuki5168 changed the title Refactor/tier4 planning rviz plugin refactor(tier4_planning_rviz_plugin): create abstract class for footprint Feb 11, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review February 11, 2023 10:51
@takayuki5168 takayuki5168 requested review from yukkysaito and a team as code owners February 11, 2023 10:51
@takayuki5168
Copy link
Contributor Author

@yukkysaito Could you review the PR.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168 takayuki5168 force-pushed the refactor/tier4-planning-rviz-plugin branch from 7a259e7 to 67baad2 Compare February 11, 2023 12:10
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the refactor/tier4-planning-rviz-plugin branch from 67baad2 to af6a10a Compare February 11, 2023 12:30
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 enabled auto-merge (squash) February 11, 2023 12:35
@takayuki5168 takayuki5168 merged commit a8caf21 into autowarefoundation:main Feb 11, 2023
@takayuki5168 takayuki5168 deleted the refactor/tier4-planning-rviz-plugin branch February 11, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants