Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(yabloc): add camera and vector map localization #3946

Merged

changed localization_mode option names

6e3977f
Select commit
Loading
Failed to load commit list.
Merged

feat(yabloc): add camera and vector map localization #3946

changed localization_mode option names
6e3977f
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jun 22, 2023 in 5m 23s

CodeScene PR Check

Quality Gates: FAILED

  • Declining Code Health: 417 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 5 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Negative Code Health Impact (highest to lowest):

  • Code Duplication scene_intersection.cpp 🔥
  • Complex Method scene_intersection.cpp 🔥
  • Complex Method utils.cpp 🔥
  • Brain Method utils.cpp 🔥
  • Brain Method utils.cpp 🔥
  • Brain Method scene_intersection.cpp 🔥
  • Brain Method scene_intersection.cpp 🔥
  • Brain Method util.cpp
  • Complex Conditional util.cpp
  • Complex Method scene_crosswalk.cpp
  • Complex Conditional scene_intersection.cpp 🔥
  • Complex Method scene_intersection.cpp 🔥
  • Bumpy Road Ahead scene_intersection.cpp 🔥
  • Complex Method util.cpp
  • Complex Method utils.cpp 🔥
  • Complex Method utils.cpp 🔥
  • Complex Method util.cpp
  • Complex Method debug.cpp
  • Complex Method scene_intersection.cpp 🔥
  • Complex Method shift_pull_out.cpp
  • Complex Method utils.cpp 🔥
  • Deep, Nested Complexity graph_segment_core.cpp
  • Overall Code Complexity segment_filter_core.cpp
  • Bumpy Road Ahead direct_cost_map.cpp
  • Deep, Nested Complexity direct_cost_map.cpp
  • Deep, Nested Complexity projector_module.cpp
  • Overall Code Complexity start_planner_module.cpp 🔥
  • Overall Code Complexity utils.cpp 🔥
  • Deep, Nested Complexity utils.cpp 🔥
  • Code Duplication expansion.cpp
  • Overall Code Complexity expansion.cpp
  • Deep, Nested Complexity expansion.cpp
  • Overall Code Complexity geometric_parallel_parking.cpp
  • Overall Code Complexity goal_searcher.cpp
  • Complex Conditional utils.cpp 🔥
  • Overall Code Complexity utils.cpp 🔥
  • Overall Code Complexity path_utils.cpp
  • Overall Code Complexity safety_check.cpp
  • Lines of Code in a Single File utils.cpp 🔥
  • Overall Code Complexity utils.cpp 🔥
  • Overall Code Complexity scene.cpp
  • Deep, Nested Complexity scene.cpp
  • Bumpy Road Ahead debug.cpp
  • Code Duplication manager.cpp
  • Overall Code Complexity scene_crosswalk.cpp
  • Deep, Nested Complexity scene_crosswalk.cpp
  • Overall Code Complexity scene.cpp
  • Deep, Nested Complexity scene.cpp
  • Code Duplication manager.cpp
  • Overall Code Complexity manager.cpp
  • Deep, Nested Complexity manager.cpp
  • Lines of Code in a Single File scene_intersection.cpp 🔥
  • Overall Code Complexity scene_intersection.cpp 🔥
  • Complex Conditional util.cpp
  • Overall Code Complexity util.cpp
  • Complex Conditional scene_no_stopping_area.cpp
  • Overall Code Complexity scene_no_stopping_area.cpp
  • Overall Code Complexity grid_utils.cpp
  • Deep, Nested Complexity grid_utils.cpp
  • Complex Conditional occlusion_spot_utils.cpp
  • Overall Code Complexity occlusion_spot_utils.cpp
  • Deep, Nested Complexity occlusion_spot_utils.cpp
  • Bumpy Road Ahead test_grid_utils.cpp
  • Deep, Nested Complexity test_grid_utils.cpp
  • Overall Code Complexity decisions.cpp
  • Deep, Nested Complexity util.cpp
  • Deep, Nested Complexity manager.cpp
  • Overall Code Complexity scene.cpp
  • Deep, Nested Complexity scene.cpp
  • Code Duplication scene.cpp
  • Bumpy Road Ahead util.cpp
  • Bumpy Road Ahead util.cpp
  • Complex Method scene_occlusion_spot.cpp
  • Complex Method scene_crosswalk.cpp
  • Complex Method path_utils.cpp
  • Large Method test_arc_lane_util.cpp
  • Complex Method segment_filter_core.cpp
  • Complex Conditional scene_intersection.cpp 🔥
  • Complex Method scene.cpp
  • Complex Method manager.cpp
  • Complex Method shift_pull_over.cpp
  • Complex Method utils.cpp 🔥
  • Bumpy Road Ahead scene_intersection.cpp 🔥
  • Complex Method camera_particle_corrector_core.cpp
  • Complex Method path_utils.cpp
  • Bumpy Road Ahead utils.cpp 🔥
  • Complex Method scene.cpp
  • Bumpy Road Ahead utils.cpp 🔥
  • Deep, Nested Complexity scene_intersection.cpp 🔥
  • Complex Method direct_cost_map.cpp
  • Complex Method scene.cpp
  • Large Method scene_out_of_lane.cpp
  • Complex Method utils.cpp 🔥
  • Complex Method utils.cpp 🔥
  • Complex Conditional utils.cpp 🔥
  • Complex Method geometric_parallel_parking.cpp
  • Complex Conditional geometric_parallel_parking.cpp
  • Complex Conditional path_shifter.cpp
  • Complex Conditional utils.cpp 🔥
  • Complex Conditional utils.cpp 🔥
  • Deep, Nested Complexity utils.cpp 🔥
  • Complex Conditional scene.cpp
  • Complex Method scene_no_stopping_area.cpp
  • Complex Method util.cpp
  • Complex Method debug.cpp
  • Bumpy Road Ahead scene_crosswalk.cpp
  • Large Method start_planner_module.cpp 🔥
  • Complex Method debug.cpp
  • Large Method test_utils.cpp
  • Deep, Nested Complexity scene_intersection.cpp 🔥
  • Complex Method scene_no_stopping_area.cpp
  • Complex Method util.cpp
  • Complex Method scene.cpp
  • Complex Method scene.cpp
  • Complex Method utils.cpp 🔥
  • Large Method test_utilization.cpp
  • Complex Method camera_pose_initializer_core.cpp
  • Complex Method geometric_parallel_parking.cpp
  • Large Method utils.cpp 🔥
  • Complex Method scene.cpp
  • Large Method start_planner_module.cpp 🔥
  • Complex Method expansion.cpp
  • Complex Method test_grid_utils.cpp
  • Complex Method decisions.cpp
  • Deep, Nested Complexity utils.cpp 🔥
  • Deep, Nested Complexity utils.cpp 🔥
  • Complex Method utils.cpp 🔥
  • Complex Method scene_crosswalk.cpp
  • Complex Method start_planner_module.cpp 🔥
  • Complex Method scene_merge_from_private_road.cpp
  • Complex Method geometric_parallel_parking.cpp
  • Complex Method lanelet2_overlay_core.cpp
  • Complex Method utils.cpp 🔥
  • Complex Method utils.cpp 🔥
  • Complex Method scene_walkway.cpp
  • Complex Method util.cpp
  • Bumpy Road Ahead utils.cpp 🔥
  • Complex Method scene.cpp
  • Deep, Nested Complexity util.cpp
  • Complex Method utils.cpp 🔥
  • Complex Method pose_initializer_core.cpp: PoseInitializer::on_initialize
  • Complex Method goal_searcher.cpp
  • Complex Method safety_check.cpp
  • Complex Method occlusion_spot_utils.cpp
  • Complex Method state_machine.cpp
  • Complex Method scene.cpp
  • Complex Method start_planner_module.cpp 🔥
  • Complex Method expansion.cpp
  • Complex Method decisions.cpp
  • Complex Method utils.cpp 🔥
  • Complex Method hierarchical_cost_map.cpp
  • Complex Method test_resampler.cpp
  • Complex Conditional start_planner_module.cpp 🔥
  • Complex Conditional start_planner_module.cpp 🔥
  • Complex Conditional start_planner_module.cpp 🔥
  • Complex Conditional utils.cpp 🔥
  • Excess Number of Function Arguments drivable_area_expansion.cpp
  • Missing Arguments Abstractions expansion.cpp
  • Primitive Obsession geometric_parallel_parking.cpp
  • Complex Method freespace_pull_over.cpp
  • Excess Number of Function Arguments util.cpp
  • Missing Arguments Abstractions utils.cpp 🔥
  • Deep, Nested Complexity utils.cpp 🔥
  • Deep, Nested Complexity utils.cpp 🔥
  • Primitive Obsession utils.cpp 🔥
  • Primitive Obsession path_shifter.cpp
  • Missing Arguments Abstractions safety_check.cpp
  • Primitive Obsession safety_check.cpp
  • Excess Number of Function Arguments util.cpp
  • Excess Number of Function Arguments util.cpp
  • Number of Functions in a Single Module utils.cpp 🔥
  • Complex Method utils.cpp 🔥
  • Complex Method utils.cpp 🔥
  • Complex Conditional utils.cpp 🔥
  • Complex Conditional utils.cpp 🔥
  • Bumpy Road Ahead utils.cpp 🔥
  • Deep, Nested Complexity utils.cpp 🔥
  • Deep, Nested Complexity utils.cpp 🔥
  • Deep, Nested Complexity utils.cpp 🔥
  • Deep, Nested Complexity utils.cpp 🔥
  • Complex Conditional scene.cpp
  • Primitive Obsession debug.cpp
  • Bumpy Road Ahead scene_intersection.cpp 🔥
  • Primitive Obsession util.cpp
  • Complex Method risk_predictive_braking.cpp
  • Complex Conditional lanelets_selection.cpp
  • Excess Number of Function Arguments lanelets_selection.cpp
  • Complex Method overlapping_range.cpp
  • Complex Method scene_out_of_lane.cpp
  • Complex Method path_utilization.cpp
  • Complex Conditional util.cpp
  • Primitive Obsession util.cpp
  • Excess Number of Function Arguments debug.cpp
  • Complex Method debug.cpp
  • Complex Method util.cpp
  • Complex Conditional debug.cpp
  • Complex Method manager.cpp
  • Complex Method calculation_time_plotter.py
  • Complex Method expansion.cpp
  • Complex Method occlusion_spot_utils.cpp
  • Complex Method scene_merge_from_private_road.cpp
  • Complex Method utils.cpp 🔥
  • Complex Method scene_crosswalk.cpp
  • Complex Method scene_crosswalk.cpp
  • Complex Method scene_crosswalk.cpp
  • Bumpy Road Ahead utils.cpp 🔥
  • Complex Method utils.cpp 🔥
  • Complex Method shift_pull_out.cpp
  • Complex Method scene.cpp
  • Complex Method scene.cpp
  • Complex Method scene.cpp
  • Complex Method drivable_area_expansion.cpp
  • Complex Method safety_check.cpp
  • Complex Method grid_utils.cpp
  • Complex Method scene.cpp
  • Deep, Nested Complexity util.cpp
  • Complex Method util.cpp
  • Bumpy Road Ahead scene_crosswalk.cpp
  • Complex Method utils.cpp 🔥
  • Complex Method utils.cpp 🔥
  • Complex Method drivable_area_expansion.cpp
  • Complex Method grid_utils.cpp
  • Complex Method grid_utils.cpp
  • Complex Method occlusion_spot_utils.cpp
  • Complex Method scene.cpp
  • Complex Method scene.cpp
  • Complex Method start_planner_module.cpp 🔥
  • Complex Method utils.cpp 🔥
  • Complex Method utils.cpp 🔥
  • Complex Method utils.cpp 🔥
  • Complex Method utils.cpp 🔥
  • Complex Method utils.cpp 🔥
  • Complex Method utils.cpp 🔥
  • Complex Method utils.cpp 🔥
  • Complex Method utils.cpp 🔥
  • Complex Method utils.cpp 🔥
  • Bumpy Road Ahead path_utils.cpp
  • Bumpy Road Ahead util.cpp
  • Bumpy Road Ahead utils.cpp 🔥
  • Bumpy Road Ahead utils.cpp 🔥
  • Complex Conditional scene_intersection.cpp 🔥
  • Bumpy Road Ahead start_planner_module.cpp 🔥
  • Bumpy Road Ahead drivable_area_expansion.cpp
  • Bumpy Road Ahead geometric_parallel_parking.cpp
  • Bumpy Road Ahead utils.cpp 🔥
  • Complex Method start_planner_module.cpp 🔥
  • Complex Method path_shifter.cpp
  • Bumpy Road Ahead path_shifter.cpp
  • Bumpy Road Ahead grid_utils.cpp
  • Bumpy Road Ahead scene_out_of_lane.cpp
  • Bumpy Road Ahead scene.cpp
  • Excess Number of Function Arguments shift_pull_out.cpp
  • Bumpy Road Ahead scene_crosswalk.cpp
  • Bumpy Road Ahead scene_crosswalk.cpp
  • Bumpy Road Ahead scene_crosswalk.cpp
  • Bumpy Road Ahead scene.cpp
  • Bumpy Road Ahead scene.cpp
  • Bumpy Road Ahead path_utils.cpp
  • Excess Number of Function Arguments path_utils.cpp
  • Excess Number of Function Arguments debug.cpp
  • Bumpy Road Ahead ground_server_core.cpp
  • Bumpy Road Ahead ll2_decomposer_core.cpp
  • Bumpy Road Ahead graph_segment_core.cpp
  • Bumpy Road Ahead similar_area_searcher.cpp
  • Bumpy Road Ahead segment_filter_core.cpp
  • Bumpy Road Ahead test_resampler.cpp
  • Bumpy Road Ahead test_resampler.cpp
  • Bumpy Road Ahead expansion.cpp
  • Bumpy Road Ahead expansion.cpp
  • Bumpy Road Ahead freespace_pull_over.cpp
  • Bumpy Road Ahead goal_searcher.cpp
  • Bumpy Road Ahead goal_searcher.cpp
  • Bumpy Road Ahead goal_searcher.cpp
  • Bumpy Road Ahead shift_pull_over.cpp
  • Bumpy Road Ahead occupancy_grid_based_collision_detector.cpp
  • Bumpy Road Ahead shift_pull_out.cpp
  • Bumpy Road Ahead utils.cpp 🔥
  • Bumpy Road Ahead utils.cpp 🔥
  • Bumpy Road Ahead utils.cpp 🔥
  • Bumpy Road Ahead debug.cpp
  • Bumpy Road Ahead manager.cpp
  • Bumpy Road Ahead manager.cpp
  • Bumpy Road Ahead scene_walkway.cpp
  • Bumpy Road Ahead debug.cpp
  • Bumpy Road Ahead scene.cpp
  • Bumpy Road Ahead scene.cpp
  • Bumpy Road Ahead manager.cpp
  • Bumpy Road Ahead scene_merge_from_private_road.cpp
  • Bumpy Road Ahead debug.cpp
  • Bumpy Road Ahead scene_no_stopping_area.cpp
  • Bumpy Road Ahead scene_no_stopping_area.cpp
  • Bumpy Road Ahead scene_occlusion_spot.cpp
  • Bumpy Road Ahead path_utilization.cpp
  • Bumpy Road Ahead util.cpp
  • Bumpy Road Ahead util.cpp
  • Bumpy Road Ahead debug.cpp
  • Bumpy Road Ahead state_machine.cpp
  • Bumpy Road Ahead debug.cpp
  • Bumpy Road Ahead scene.cpp
  • Bumpy Road Ahead util.cpp
  • Bumpy Road Ahead scene.cpp
  • Bumpy Road Ahead manager.cpp
  • Bumpy Road Ahead debug.cpp
  • Bumpy Road Ahead scene.cpp
  • Bumpy Road Ahead scene.cpp
  • Bumpy Road Ahead scene.cpp
  • Bumpy Road Ahead calculation_time_plotter.py
  • Complex Method path_shifter.cpp
  • Complex Method path_shifter.cpp
  • Bumpy Road Ahead utils.cpp 🔥
  • Bumpy Road Ahead utils.cpp 🔥
  • Bumpy Road Ahead util.cpp
  • Bumpy Road Ahead utils.cpp 🔥
  • Bumpy Road Ahead utils.cpp 🔥
  • Excess Number of Function Arguments debug.cpp
  • Excess Number of Function Arguments path_utils.cpp
  • Excess Number of Function Arguments grid_utils.cpp
  • Bumpy Road Ahead start_planner_module.cpp 🔥
  • Bumpy Road Ahead start_planner_module.cpp 🔥
  • Bumpy Road Ahead start_planner_module.cpp 🔥
  • Bumpy Road Ahead geometric_parallel_parking.cpp
  • Bumpy Road Ahead geometric_parallel_parking.cpp
  • Bumpy Road Ahead geometric_parallel_parking.cpp
  • Excess Number of Function Arguments safety_check.cpp
  • Excess Number of Function Arguments shift_pull_out.cpp
  • Bumpy Road Ahead path_shifter.cpp
  • Bumpy Road Ahead grid_utils.cpp
  • Bumpy Road Ahead scene_out_of_lane.cpp
  • Bumpy Road Ahead scene.cpp
  • Excess Number of Function Arguments safety_check.cpp
  • Bumpy Road Ahead scene.cpp
  • Excess Number of Function Arguments scene.cpp
  • Bumpy Road Ahead path_utils.cpp
  • Bumpy Road Ahead path_utils.cpp
  • Bumpy Road Ahead drivable_area_expansion.cpp
  • Bumpy Road Ahead utils.cpp 🔥
  • Bumpy Road Ahead utils.cpp 🔥
  • Bumpy Road Ahead utils.cpp 🔥
  • Bumpy Road Ahead utils.cpp 🔥
  • Bumpy Road Ahead utils.cpp 🔥
  • Bumpy Road Ahead utils.cpp 🔥
  • Bumpy Road Ahead utils.cpp 🔥
  • Bumpy Road Ahead utils.cpp 🔥
  • Bumpy Road Ahead utils.cpp 🔥
  • Bumpy Road Ahead utils.cpp 🔥
  • Bumpy Road Ahead utils.cpp 🔥
  • Excess Number of Function Arguments debug.cpp
  • Excess Number of Function Arguments debug.cpp
  • Excess Number of Function Arguments debug.cpp
  • Excess Number of Function Arguments scene.cpp
  • Excess Number of Function Arguments scene.cpp
  • Excess Number of Function Arguments scene.cpp
  • Excess Number of Function Arguments geometric_parallel_parking.cpp
  • Excess Number of Function Arguments scene.cpp
  • Excess Number of Function Arguments scene.cpp
  • Excess Number of Function Arguments grid_utils.cpp
  • Excess Number of Function Arguments occlusion_spot_utils.cpp
  • Excess Number of Function Arguments geometric_parallel_parking.cpp
  • Excess Number of Function Arguments debug.cpp
  • Excess Number of Function Arguments debug.cpp
  • Excess Number of Function Arguments debug.cpp
  • Excess Number of Function Arguments occlusion_spot_utils.cpp
  • Excess Number of Function Arguments expansion.cpp
  • Excess Number of Function Arguments expansion.cpp
  • Excess Number of Function Arguments expansion.cpp
  • Excess Number of Function Arguments expansion.cpp
  • Excess Number of Function Arguments grid_utils.cpp
  • Excess Number of Function Arguments util.cpp
  • Excess Number of Function Arguments geometric_parallel_parking.cpp
  • Excess Number of Function Arguments util.cpp
  • Excess Number of Function Arguments occlusion_spot_utils.cpp
  • Excess Number of Function Arguments occlusion_spot_utils.cpp
  • Excess Number of Function Arguments util.cpp
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments util.cpp
  • Excess Number of Function Arguments debug.cpp
  • Excess Number of Function Arguments geometric_parallel_parking.cpp
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments safety_check.cpp
  • Excess Number of Function Arguments util.cpp
  • Excess Number of Function Arguments util.cpp
  • Excess Number of Function Arguments util.cpp
  • Excess Number of Function Arguments util.cpp
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments scene_intersection.cpp 🔥
  • Excess Number of Function Arguments scene_intersection.cpp 🔥
  • Excess Number of Function Arguments scene_intersection.cpp 🔥
  • Excess Number of Function Arguments scene_intersection.cpp 🔥
  • Excess Number of Function Arguments util.cpp
  • Excess Number of Function Arguments util.cpp
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments scene_intersection.cpp 🔥
  • Excess Number of Function Arguments scene_intersection.cpp 🔥
  • Excess Number of Function Arguments scene_intersection.cpp 🔥
  • Excess Number of Function Arguments util.cpp
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments utils.cpp 🔥
  • Excess Number of Function Arguments utils.cpp 🔥

Annotations

Check warning on line 96 in localization/pose_initializer/src/pose_initializer/pose_initializer_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

PoseInitializer::on_initialize increases in cyclomatic complexity from 11 to 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 1 in planning/behavior_path_planner/test/test_utils.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Method

TEST:BehaviorPathPlanningUtilitiesBehaviorTest:expandLanelets has 76 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 1 in planning/behavior_path_planner/src/utils/drivable_area_expansion/drivable_area_expansion.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

findLeftRightRanges has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 1 in planning/behavior_path_planner/src/utils/drivable_area_expansion/drivable_area_expansion.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

updateDrivableAreaBounds has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 1 in planning/behavior_path_planner/src/utils/drivable_area_expansion/drivable_area_expansion.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

updateDrivableAreaBounds has 4 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 1 in planning/behavior_path_planner/src/utils/drivable_area_expansion/drivable_area_expansion.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

findLeftRightRanges has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 1 in planning/behavior_path_planner/src/utils/drivable_area_expansion/drivable_area_expansion.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

expandDrivableArea has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check warning on line 1 in planning/behavior_path_planner/src/utils/drivable_area_expansion/expansion.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Code Duplication

The module contains 2 functions with similar structure: calculateDistanceLimit,calculateDistanceLimit. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.

Check warning on line 1 in planning/behavior_path_planner/src/utils/drivable_area_expansion/expansion.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

createExpansionLaneletPolygons has a cyclomatic complexity of 14, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 1 in planning/behavior_path_planner/src/utils/drivable_area_expansion/expansion.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

calculate_arc_length_range_and_distance has a cyclomatic complexity of 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 1 in planning/behavior_path_planner/src/utils/drivable_area_expansion/expansion.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

createExpansionPolygons has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 1 in planning/behavior_path_planner/src/utils/drivable_area_expansion/expansion.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

calculate_arc_length_range_and_distance has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 1 in planning/behavior_path_planner/src/utils/drivable_area_expansion/expansion.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

createExpansionLaneletPolygons has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 1 in planning/behavior_path_planner/src/utils/drivable_area_expansion/expansion.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Overall Code Complexity

This module has a mean cyclomatic complexity of 7.29 across 7 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check warning on line 1 in planning/behavior_path_planner/src/utils/drivable_area_expansion/expansion.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

createExpansionPolygons has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.

Check warning on line 1 in planning/behavior_path_planner/src/utils/drivable_area_expansion/expansion.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Missing Arguments Abstractions

The average number of function arguments in this module is 4.14 across 7 functions. The average arguments threshold is 4.00. The functions in this file have too many arguments, indicating a lack of encapsulation or too many responsibilities in the same functions. Avoid adding more.

Check warning on line 1 in planning/behavior_path_planner/src/utils/drivable_area_expansion/expansion.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

calculate_arc_length_range_and_distance has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check warning on line 1 in planning/behavior_path_planner/src/utils/drivable_area_expansion/expansion.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

create_compensation_polygon has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check warning on line 1 in planning/behavior_path_planner/src/utils/drivable_area_expansion/expansion.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

createExpansionPolygons has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check warning on line 1 in planning/behavior_path_planner/src/utils/drivable_area_expansion/expansion.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

createExpansionLaneletPolygons has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check warning on line 1 in planning/behavior_path_planner/src/utils/geometric_parallel_parking/geometric_parallel_parking.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

GeometricParallelParking::planPullOut has a cyclomatic complexity of 14, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 1 in planning/behavior_path_planner/src/utils/geometric_parallel_parking/geometric_parallel_parking.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

GeometricParallelParking::planPullOver has a cyclomatic complexity of 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 1 in planning/behavior_path_planner/src/utils/geometric_parallel_parking/geometric_parallel_parking.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

GeometricParallelParking::planOneTrial has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 1 in planning/behavior_path_planner/src/utils/geometric_parallel_parking/geometric_parallel_parking.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional

GeometricParallelParking::generateArcPathPoint has 1 complex conditionals with 3 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check warning on line 1 in planning/behavior_path_planner/src/utils/geometric_parallel_parking/geometric_parallel_parking.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

GeometricParallelParking::planOneTrial has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.