fix(log-messages): reduce excessive log messages #6406

ahmeddesokyebrahim · 2024-02-14T08:53:25Z

Description

This PR is one of group of PRs that aim to fix Autoware logging system to achieve the goal of reducing excessive error and warning logs on Autoware launch.

Part of:

Reduce excessive error and warning logs on Autoware launch #5539

Tests performed

Planning Simulation
- Run Autoware planning simulator and you can see no more excessive and recurring error, warning, and info message when the system running as expected
Rosbag Replay Simulation
- Run Autoware rosbag repay simulation and you can see no more excessive and recurring error, warning, and info message when the system running as expected
AWSIM
- To be addressed in another PR - extended goal)

Notes for reviewers

Take into consideration relevant PRs.

Interface changes

N.A

Effects on system behavior

Improved console output => better developer experience specially for debugging and catching actual problems.
Some recurrent info messages are lowered to debug level. So the developer would need to set the logger level of that specific node to see the debug message.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.
The PR has been properly tested.
The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.
The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

codecov · 2024-02-29T15:25:46Z

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 14.80%. Comparing base (c1b8f46) to head (b6758d9).
Report is 3 commits behind head on main.

Files	Patch %	Lines
...atenate_data/concatenate_and_time_sync_nodelet.cpp	0.00%	2 Missing ⚠️
...zation/localization_util/src/smart_pose_buffer.cpp	0.00%	1 Missing ⚠️
localization/localization_util/src/util_func.cpp	0.00%	1 Missing ⚠️
...ization/ndt_scan_matcher/src/map_update_module.cpp	0.00%	1 Missing ⚠️
...ion/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp	0.00%	1 Missing ⚠️
sensing/pointcloud_preprocessor/src/filter.cpp	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6406   +/-   ##
=======================================
  Coverage   14.80%   14.80%           
=======================================
  Files        1915     1915           
  Lines      132258   132257    -1     
  Branches    39320    39316    -4     
=======================================
  Hits        19577    19577           
  Misses      90847    90847           
+ Partials    21834    21833    -1

Flag	Coverage Δ		*Carryforward flag
differential	`6.66% <0.00%> (?)`
total	`14.80% <ø> (+<0.01%)`	⬆️	Carriedforward from c1b8f46

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

localization/pose_initializer/src/pose_initializer/ndt_module.cpp

YamatoAndo

LGTM about the localizaiton module

ahmeddesokyebrahim · 2024-03-12T03:59:57Z

@xmfcx will it be possible that you have a look to this PR ?
It is quite straightforward one.
Thanks for your continuous support !

…and_time_sync_nodelet for info about subscribing to topics and their names Signed-off-by: Ahmed Ebrahim <ahmed.ebrahim@leodrive.ai>

…that there is a mismatch in timestamp Signed-off-by: Ahmed Ebrahim <ahmed.ebrahim@leodrive.ai>

Signed-off-by: Ahmed Ebrahim <ahmed.ebrahim@leodrive.ai>

miursh · 2024-03-12T06:22:45Z

sensing/pointcloud_preprocessor/src/concatenate_data/concatenate_and_time_sync_nodelet.cpp

@@ -145,10 +145,10 @@ PointCloudConcatenateDataSynchronizerComponent::PointCloudConcatenateDataSynchro

  // Subscribers
  {
-    RCLCPP_INFO_STREAM(


[imo]
This is just printed during the initialization process.
Can we keep this as INFO?

yukkysaito

LGTM

…6406) * fix(log-messages): lower log level from info to debug in concatenate_and_time_sync_nodelet for info about subscribing to topics and their names Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com> * fix(log-messages): adding info print in smart_pose_buffer indicating that there is a mismatch in timestamp Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com> * fix(log-messages): removing info msg that is redundant with error msg Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com> * fix(log-messages): lower some info msgs to debug Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com> --------- Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com> Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>

…6406) * fix(log-messages): lower log level from info to debug in concatenate_and_time_sync_nodelet for info about subscribing to topics and their names Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com> * fix(log-messages): adding info print in smart_pose_buffer indicating that there is a mismatch in timestamp Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com> * fix(log-messages): removing info msg that is redundant with error msg Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com> * fix(log-messages): lower some info msgs to debug Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com> --------- Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>

ahmeddesokyebrahim self-assigned this Feb 14, 2024

github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Feb 14, 2024

ahmeddesokyebrahim mentioned this pull request Feb 15, 2024

Reduce excessive error and warning logs on Autoware launch #5539

Open

8 tasks

ktro2828 changed the title ~~fix(log-messages): reduce excessive log messages~~ fix(log-messages): reduce excessive log messages Feb 20, 2024

ahmeddesokyebrahim force-pushed the autoware/universe/5539-fix-log-messages-rosbag-replay-simulation branch from f0a6cfb to ca4a381 Compare February 20, 2024 13:02

github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Feb 20, 2024

ahmeddesokyebrahim force-pushed the autoware/universe/5539-fix-log-messages-rosbag-replay-simulation branch from 6bb55d0 to 8b8a2c5 Compare February 29, 2024 14:43

ahmeddesokyebrahim marked this pull request as ready for review February 29, 2024 14:55

ahmeddesokyebrahim requested review from amc-nu, kyoichi-sugahara, miursh, yukkysaito, anhnv3991, isamu-takagi, KYabuuchi, Motsu-san, RyuYamamoto, SakodaShintaro, TaikiYamada4, YamatoAndo and kminoda as code owners February 29, 2024 14:55

ahmeddesokyebrahim added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 29, 2024

ahmeddesokyebrahim requested review from xmfcx and mitsudome-r February 29, 2024 14:56

YamatoAndo reviewed Mar 4, 2024

View reviewed changes

localization/pose_initializer/src/pose_initializer/ndt_module.cpp Show resolved Hide resolved

YamatoAndo approved these changes Mar 4, 2024

View reviewed changes

mitsudome-r approved these changes Mar 5, 2024

View reviewed changes

mitsudome-r enabled auto-merge (squash) March 11, 2024 07:09

ahmeddesokyebrahim force-pushed the autoware/universe/5539-fix-log-messages-rosbag-replay-simulation branch from 8b8a2c5 to 61458f8 Compare March 12, 2024 04:01

ahmeddesokyebrahim requested a review from badai-nguyen as a code owner March 12, 2024 04:01

ahmeddesokyebrahim added 4 commits March 12, 2024 06:03

fix(log-messages): lower log level from info to debug in concatenate_…

923bbc2

…and_time_sync_nodelet for info about subscribing to topics and their names Signed-off-by: Ahmed Ebrahim <ahmed.ebrahim@leodrive.ai>

fix(log-messages): adding info print in smart_pose_buffer indicating …

0ca560a

…that there is a mismatch in timestamp Signed-off-by: Ahmed Ebrahim <ahmed.ebrahim@leodrive.ai>

fix(log-messages): removing info msg that is redundant with error msg

37587c9

Signed-off-by: Ahmed Ebrahim <ahmed.ebrahim@leodrive.ai>

fix(log-messages): lower some info msgs to debug

b6758d9

Signed-off-by: Ahmed Ebrahim <ahmed.ebrahim@leodrive.ai>

ahmeddesokyebrahim force-pushed the autoware/universe/5539-fix-log-messages-rosbag-replay-simulation branch from 61458f8 to b6758d9 Compare March 12, 2024 04:04

miursh reviewed Mar 12, 2024

View reviewed changes

yukkysaito approved these changes Mar 12, 2024

View reviewed changes

mitsudome-r merged commit 4747e74 into autowarefoundation:main Mar 12, 2024
26 of 27 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(log-messages): reduce excessive log messages #6406

fix(log-messages): reduce excessive log messages #6406

ahmeddesokyebrahim commented Feb 14, 2024

codecov bot commented Feb 29, 2024 •

edited

Loading

YamatoAndo left a comment •

edited

Loading

ahmeddesokyebrahim commented Mar 12, 2024 •

edited

Loading

miursh Mar 12, 2024

yukkysaito left a comment

fix(log-messages): reduce excessive log messages #6406

fix(log-messages): reduce excessive log messages #6406

Conversation

ahmeddesokyebrahim commented Feb 14, 2024

Description

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov bot commented Feb 29, 2024 • edited Loading

Codecov Report

YamatoAndo left a comment • edited Loading

Choose a reason for hiding this comment

ahmeddesokyebrahim commented Mar 12, 2024 • edited Loading

miursh Mar 12, 2024

Choose a reason for hiding this comment

yukkysaito left a comment

Choose a reason for hiding this comment

codecov bot commented Feb 29, 2024 •

edited

Loading

YamatoAndo left a comment •

edited

Loading

ahmeddesokyebrahim commented Mar 12, 2024 •

edited

Loading