Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(freespace_planner): fix parking trajectory errors and warnings when parking completed #6696

Conversation

ahmeddesokyebrahim
Copy link
Contributor

@ahmeddesokyebrahim ahmeddesokyebrahim commented Mar 28, 2024

Description

fixes #6380
fixes #6378
fixes #6381

Related links

This PR is one of group of PRs that aim to fix Autoware logging system to achieve the goal of reducing excessive error and warning logs on Autoware launch.

Part of:

Related links

More details in the issue.

Tests performed

Notes for reviewers

Interface changes

N.A

Effects on system behavior

The errors and warnings mentioned in #6380 , #6378, and #6381 are no longer occuring.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…igate topic timeout

Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
@ahmeddesokyebrahim ahmeddesokyebrahim self-assigned this Mar 28, 2024
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 28, 2024
@ahmeddesokyebrahim ahmeddesokyebrahim marked this pull request as ready for review March 28, 2024 05:31
@ahmeddesokyebrahim ahmeddesokyebrahim added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 14.94%. Comparing base (dd7c252) to head (3f79724).
Report is 1 commits behind head on main.

Files Patch % Lines
...r/src/freespace_planner/freespace_planner_node.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6696   +/-   ##
=======================================
  Coverage   14.94%   14.94%           
=======================================
  Files        1937     1937           
  Lines      133613   133616    +3     
  Branches    39751    39752    +1     
=======================================
+ Hits        19971    19972    +1     
- Misses      91396    91399    +3     
+ Partials    22246    22245    -1     
Flag Coverage Δ *Carryforward flag
differential 30.07% <0.00%> (?)
total 14.94% <ø> (ø) Carriedforward from dd7c252

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ahmeddesokyebrahim ahmeddesokyebrahim merged commit 6d7cd0a into autowarefoundation:main Mar 28, 2024
42 of 45 checks passed
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…en parking completed (autowarefoundation#6696)

fix(freespace_planner): publish stop trajectory when completed to mitigate topic timeout

Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
2 participants