feat(route_handler): add unit tests #6961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
maxime-clem
added
the
tag:run-build-and-test-differential
zulfaqar-azmi-t4
requested review from
rej55,
kosuke55,
soblin and
takayuki5168
as code owners
zulfaqar-azmi-t4
force-pushed
the
route-handler-unit-test
branch
from
a904ef7
to
1970163
Compare
zulfaqar-azmi-t4
force-pushed
the
route-handler-unit-test
branch
from
1970163
to
959b8a9
Compare
zulfaqar-azmi-t4
removed
the
tag:run-build-and-test-differential
auto-merge was automatically disabled
May 14, 2024 14:21
Pull request was converted to draft
zulfaqar-azmi-t4
force-pushed
the
route-handler-unit-test
branch
from
959b8a9
to
3f3ed45
Compare
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4
force-pushed
the
route-handler-unit-test
branch
from
66a8518
to
5563a6d
Compare
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4
requested review from
go-sakayori,
kyoichi-sugahara and
TakaHoribe
as code owners
zulfaqar-azmi-t4
added
the
tag:run-build-and-test-differential
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4
added
the
tag:deploy-docs
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
github-actions
bot
added
the
type:documentation
soblin
approved these changes
May 20, 2024
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4
merged commit b0a0a39
into
autowarefoundation:main
21 of 22 checks passed
zulfaqar-azmi-t4
added a commit
to zulfaqar-azmi-t4/autoware.universe
that referenced
this pull request
May 28, 2024
* feat(route_handler): add unit tests Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Added route parser Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Completed parser Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Added route file for later test Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * pre-commit Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Added test for isHandlerReady Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix some cppcheck error Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Added additional test Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * move to planning test utils Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * renaming route_parser Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * rename function Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Renaming several things Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * style(pre-commit): autofix * remove some function Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * add additional test Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Update README Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Add more explanation in the readme Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * style(pre-commit): autofix * fix lane change test route width Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add and start unit testing for route handler packages. To avoid numeric inputs (for example start and goal poses) to be hard coded, mock data parser is added. The objective of the mock data parser is to simulate output from mission planner.
Related links
None
Tests performed
colcon test
Notes for reviewers
Currently route parser is added to the route handler. Although it is weird, at the moment we do not have any consideration on where to actually place it. If in the future, other packages want to use it for testing, it will be moved into a much more suitable place.
Interface changes
None
ROS Topic Changes
None
ROS Parameter Changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.