Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lidar_centerpoint): accelerated preprocessing for centerpoint #6989

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

knzo25
Copy link
Contributor

@knzo25 knzo25 commented May 12, 2024

Description

While changing the point type to the new standard, realized that preprocessing was bottleneck in centerpoint.
Apologies to Amadeusz since he did almost the same already in transfusion, and I forgot until writing this PR but I also moved the preprocessing to cuda for gpu acceleration.

During tests in my desktop the detection time went from 16.9ms to 13.0ms, making preprocessing about ~1ms if we forcefully add syncs to measure the time.

Related links

Tests performed

  • Tested using data from the taxi

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@knzo25 knzo25 self-assigned this May 12, 2024
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label May 12, 2024
@knzo25 knzo25 changed the title feat: accelerated preprocessing for centerpoint feat(lidar_centerpoint): accelerated preprocessing for centerpoint May 12, 2024
@knzo25 knzo25 marked this pull request as ready for review May 13, 2024 04:09
@knzo25 knzo25 requested a review from kminoda as a code owner May 13, 2024 04:09
@knzo25
Copy link
Contributor Author

knzo25 commented May 13, 2024

@kminoda
This is by no means urgent, but it is always nice to reduce the perception latency.

if you do not feel comfortable reviewing this PR, Uetake-san, Hirabayashi-san, Tanaka-san, and Amadeusz are good candidates)

@kminoda kminoda added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 13, 2024
@kminoda
Copy link
Contributor

kminoda commented May 13, 2024

@knzo25 Thank you! And yes, I am still catching up with this package (especially the CUDA part), so would be nice if someone else could review it as a co-reviewer 🙏

@amadeuszsz Hi, would you help me out reviewing CUDA related code?

@kminoda
Copy link
Contributor

kminoda commented May 13, 2024

@knzo25 And also, would you execute Autoware Evaluator and verify that the basic scenarios would pass? Let me know if you don't know how to execute it.

Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the awesome PR 🚀

@knzo25
Copy link
Contributor Author

knzo25 commented May 13, 2024

@kminoda
Regarding the evaluation I will look into it as soon as I can (got other stuff to deliver first)

@amadeuszsz
Copy link
Contributor

@amadeuszsz Hi, would you help me out reviewing CUDA related code?

@kminoda
Sure! I would like to make a review next week. Please let me know if it's urgent, I might change my priorities.
I guess you can't add me as a reviewer yet. I added my account to the contributors sheet, so I hope we will be able assign me soon.

@kminoda
Copy link
Contributor

kminoda commented May 14, 2024

@amadeuszsz Thank you. Not an urgent task, so please review this when you have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants