fix(avoidance): transit rtc cooperate state to FAILED from RUNNING #6998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
satoshi-ota
force-pushed
the
feat/avoidance-rtc-new-field
branch
3 times, most recently
from
209f407
to
7434270
Compare
…s avoidance path Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
force-pushed
the
feat/avoidance-rtc-new-field
branch
from
7434270
to
555a744
Compare
satoshi-ota
requested review from
rej55,
go-sakayori,
kyoichi-sugahara,
shmpwk,
TakaHoribe,
TomohitoAndo,
tkimura4 and
zulfaqar-azmi-t4
as code owners
satoshi-ota
added
the
tag:run-build-and-test-differential
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After this PR, avoidance module doesn't remove rtc cooperate status even when the maneuver is canceled. It set
State::FAILEDto rtc state and keep publishing canceled rtc cooperate status.simplescreenrecorder-2024-05-21_19.12.44.mp4
Tests performed
Effects on system behavior
Nothing.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.