refactor(planning_test_utils): separate hpp and cpp #7082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4
requested review from
kyoichi-sugahara,
soblin and
TakaHoribe
as code owners
github-actions
bot
added
the
component:planning
zulfaqar-azmi-t4
added
the
tag:run-build-and-test-differential
| template <typename T> | ||
| void publishToTargetNode( | ||
| rclcpp::Node::SharedPtr test_node, rclcpp::Node::SharedPtr target_node, std::string topic_name, | ||
| typename rclcpp::Publisher<T>::SharedPtr publisher, T data, const int repeat_count = 3) | ||
| { | ||
| if (topic_name.empty()) { | ||
| int status; | ||
| int status = 1; |
There was a problem hiding this comment.
very small question for my future code,
What's the motivation for this?
There was a problem hiding this comment.
It's always a good practice to initialize value.
| * @param center_line_resolution The resolution for the centerline. | ||
| * @return A HADMapBin message containing the map data. | ||
| */ | ||
| HADMapBin make_map_bin_msg( |
There was a problem hiding this comment.
Do you have any distinguish between snake case and camel case?
(I know snake case is recommended for function name though
There was a problem hiding this comment.
@kyoichi-sugahara
For old function, I keep it as camelCase to avoid having to change other code. For new function, I used snake_case.
kyoichi-sugahara
approved these changes
May 27, 2024
zulfaqar-azmi-t4
merged commit 84e33d8
into
autowarefoundation:main
42 of 45 checks passed
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…on#7082) Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
…on#7082) Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separate the inplementation in the header file to cpp file.
Added doxygen comments
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.