Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ekf_localizer): componentize EKFLocalizer #7104

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented May 23, 2024

Description

Componentize the node in localization/ekf_localizer.
(Add glog feature to localization/EKFLocalizer)

Log output is changed from "screen" to "both".

Tests performed

confirmed that killing the ekf_localizer process will output logs to terminal and log file

1716453784.8813169 [ekf_localizer_node-41] [INFO] [1716453784.880840557] [rclcpp]: signal_handler(signum=15)
1716453784.8814514 [ekf_localizer_node-41] *** Aborted at 1716453784 (unix time) try "date -d @1716453784" if you are using GNU date ***
1716453784.8819714 [ekf_localizer_node-41] PC: @                0x0 (unknown)
1716453784.8823733 [ekf_localizer_node-41] *** SIGTERM (@0x3e8001c1f43) received by PID 851450 (TID 0x7f7f35118680) from PID 1843011; stack trace: ***
1716453784.8827302 [ekf_localizer_node-41]     @     0x7f7f359b54d6 google::(anonymous namespace)::FailureSignalHandler()
1716453784.8830881 [ekf_localizer_node-41]     @     0x7f7f35819ded rclcpp::SignalHandler::signal_handler()
1716453784.8834450 [ekf_localizer_node-41]     @     0x7f7f34e42520 (unknown)
1716453784.8838010 [ekf_localizer_node-41]     @     0x7f7f34e91117 (unknown)
1716453784.8838553 [ekf_localizer_node-41]     @     0x7f7f34e93e9b pthread_cond_timedwait
1716453784.8842008 [ekf_localizer_node-41]     @     0x7f7f34d84b19 ddsrt_cond_waituntil
1716453784.8842552 [ekf_localizer_node-41]     @     0x7f7f34d6b45d (unknown)
1716453784.8846004 [ekf_localizer_node-41]     @     0x7f7f350c174f rmw_wait
1716453784.8849542 [ekf_localizer_node-41]     @     0x7f7f355eb848 rcl_wait
1716453784.8853197 [ekf_localizer_node-41]     @     0x7f7f357611b6 rclcpp::Executor::wait_for_work()
1716453784.8856831 [ekf_localizer_node-41]     @     0x7f7f357616d3 rclcpp::Executor::get_next_executable()
1716453784.8860505 [ekf_localizer_node-41]     @     0x7f7f35765c81 rclcpp::executors::SingleThreadedExecutor::spin()
1716453784.8861063 [ekf_localizer_node-41]     @     0x55e5b6d4f486 main
1716453784.8864622 [ekf_localizer_node-41]     @     0x7f7f34e29d90 (unknown)
1716453784.8868330 [ekf_localizer_node-41]     @     0x7f7f34e29e40 __libc_start_main
1716453784.8868895 [ekf_localizer_node-41]     @     0x55e5b6d4fe35 _start
1716453784.8884807 [ERROR] [ekf_localizer_node-41]: process has died ... (omit)

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label May 23, 2024
@SakodaShintaro SakodaShintaro added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 24, 2024
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that glog correctly outputs errors and that there is no difference in performance from the previous version.
Thank you!

@SakodaShintaro SakodaShintaro merged commit 583cd85 into autowarefoundation:main May 24, 2024
33 of 35 checks passed
@a-maumau a-maumau changed the title feat(localization_error_monitor): componentize EKFLocalizer feat(ekf_localizer.): componentize EKFLocalizer May 24, 2024
@a-maumau a-maumau changed the title feat(ekf_localizer.): componentize EKFLocalizer feat(ekf_localizer): componentize EKFLocalizer May 24, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…foundation#7104)

* remove unusing main func file

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* add and mod to use glog

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
a-maumau added a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
…foundation#7104)

* remove unusing main func file

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* add and mod to use glog

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants