Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme.md): improve shields #4641

Closed
wants to merge 3 commits into from
Closed

docs(readme.md): improve shields #4641

wants to merge 3 commits into from

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Apr 19, 2024

Description

See below

Tests performed

Checked the links.

Use https://github.com/autowarefoundation/autoware/blob/0ed7c6d5e882d5f8b8cd2f189ab149f541b2454f/README.md to test it.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx xmfcx added the type:documentation Creating or refining documentation. label Apr 19, 2024
@xmfcx xmfcx self-assigned this Apr 19, 2024
@xmfcx
Copy link
Contributor Author

xmfcx commented Apr 19, 2024

Before

Screenshot from 2024-04-19 16-49-17

After

Screenshot from 2024-04-19 16-49-05

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xmfcx xmfcx enabled auto-merge (squash) April 19, 2024 14:08
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@xmfcx
Copy link
Contributor Author

xmfcx commented Apr 19, 2024

f4853e2

Merged.

@xmfcx xmfcx closed this Apr 19, 2024
@xmfcx xmfcx deleted the docs/readme-shields branch April 19, 2024 15:25
github-actions bot pushed a commit that referenced this pull request Apr 19, 2024
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
oguzkaganozt pushed a commit that referenced this pull request Apr 30, 2024
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Creating or refining documentation.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants