Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: support ROS 2 Humble #330

Closed
wants to merge 8 commits into from
Closed

feat: support ROS 2 Humble #330

wants to merge 8 commits into from

Conversation

kenji-miyake
Copy link
Contributor

@kenji-miyake kenji-miyake commented May 22, 2022

Description

Resolves autowarefoundation/autoware#2443.

I won't merge this PR to main until Galactic support by the AWF ends.
Users have to switch branches if they want to use Humble because it would be too complex if we support both distros in one branch.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@ghost
Copy link

ghost commented May 24, 2022

Given that it may take Autoware users some time to upgrade all of their dev platforms and ECUs to Ubuntu 22.04, would it perhaps be better to merge this PR into main in advance of Galactic reaching end of support? 🤔

@kenji-miyake
Copy link
Contributor Author

@LalithVipulananthan Yes, the current proposal is around the end of August.
autowarefoundation/autoware#358

autoware.repos Outdated
Comment on lines 102 to 98
# https://github.com/gazebo-release/gz-math6-release/issues/11
missing_packages/velodyne_simulator:
type: git
url: https://github.com/tier4/velodyne_simulator.git
version: prepare/humble
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# https://github.com/gazebo-release/gz-math6-release/issues/11
missing_packages/velodyne_simulator:
type: git
url: https://github.com/tier4/velodyne_simulator.git
version: prepare/humble

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kenji-miyake I think the issue has been resolved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kenji-miyake kenji-miyake force-pushed the humble branch 2 times, most recently from 6a9a06b to 99de4dc Compare May 24, 2022 12:36
@kenji-miyake
Copy link
Contributor Author

kenji-miyake commented May 25, 2022

Similar problem to gazebo-release/gz-math6-release#11.
https://github.com/autowarefoundation/autoware/runs/6585085834?check_suite_focus=true

 libjson-c-dev : Depends: libjson-c5 (= 0.15-2build4) but 0.15-3~ubuntu1.22.04.1 is to be installed
E: Unable to correct problems, you have held broken packages.
ERROR: the following rosdeps failed to install
  apt: command [apt-get install -y libpcl-dev] failed

But rosdep install in the build CI passed? 🤔
https://github.com/autowarefoundation/autoware/runs/6585145537?check_suite_focus=true

@wep21
Copy link
Contributor

wep21 commented Jun 22, 2022

@kenji-miyake There are some conflicts. Could you resolve them?

Kenji Miyake and others added 8 commits June 23, 2022 09:52
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Signed-off-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@kenji-miyake
Copy link
Contributor Author

A new error? 🤔
https://github.com/autowarefoundation/autoware/runs/7015153176?check_suite_focus=true#step:8:7434

The following packages have unmet dependencies:
 libudev-dev : Depends: libudev1 (= 249.11-0ubuntu3) but 249.11-0ubuntu3.3 is to be installed
E: Unable to correct problems, you have held broken packages.
ERROR: the following rosdeps failed to install
  apt: command [apt-get install -y ros-humble-joy] failed

@kenji-miyake
Copy link
Contributor Author

Moved to autowarefoundation/autoware#2692.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ROS 2 Humble
3 participants