Adding ros2_socketcan_msgs #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kenji-miyake or @mitsudome-r friendly ping. |
Signed-off-by: Joshua Whitley <whitleysoftwareservices@gmail.com>
kenji-miyake
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
@JWhitleyWork I'm so sorry. I was extremely busy recently. 🥺
Seeing the discussions between other developers, it looks good to me.
Could you consider whether to use uint8[<=64] or not based on this comment?
#26 (comment)
|
@xmfcx @mitsudome-r Could you also review this PR? 🙏 |
Done. |
Signed-off-by: Joshua Whitley <josh@electrifiedautonomy.com>
xmfcx
approved these changes
Nov 21, 2022
|
@JWhitleyWork Is it better to create new release? |
Not yet. I need to actually add CAN-FD support to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #21, this adds a new package,
ros2_socketcan_msgs. This is per option 3 in that issue.