Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sounds: not working correctly #20

Closed
ltjessem opened this issue May 2, 2022 · 2 comments
Closed

sounds: not working correctly #20

ltjessem opened this issue May 2, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@ltjessem
Copy link
Contributor

ltjessem commented May 2, 2022

equip: works, but volume: adjusts the pitch and pitch: adjusts the volume.
advancedEquip: and unequip: do not appear to function at all.

Example config:

   sounds:
      equip:
        enabled: true
        sound: "block_beacon_activate"
        volume: 2  # This is adjusting the pitch
        pitch: 1
      advancedEquip:
        enabled: true
        sound: "block_beacon_activate"
        volume: 1
        pitch: 1
      unequip:
        enabled: true
        sound: "block_beacon_deactivate"
        volume: 1
        pitch: 1
@ltjessem ltjessem added the bug Something isn't working label May 2, 2022
@ltjessem
Copy link
Contributor Author

ltjessem commented May 5, 2022

They all use sounds.equip.enabled here. Changing these to the correct values fixes advancedEquip, but unequip, volume and pitch are still broken.

@ltjessem ltjessem mentioned this issue May 5, 2022
@ltjessem
Copy link
Contributor Author

Should be a super simple fix.

@WillFP WillFP closed this as completed in 74786ee Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant