Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow Tx Gossip #274

Closed
joshua-kim opened this issue Jul 5, 2023 · 2 comments
Closed

Slow Tx Gossip #274

joshua-kim opened this issue Jul 5, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@joshua-kim
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

Coreth has as bug where transactions slow down as they are gossiped through the network. Nodes only gossip a tx if they haven't heard of it before, so once a majority of nodes hear of a transaction less and less nodes are willing to gossip the transaction. In the case that we gossip to a node that already knows of a transaction, it "aborbs" the gossip and doesn't forward it. This results in nodes potentially never even hearing about some transactions until a regossip cycle is hit.

We can use a pull-based strategy to make txs propagate exponentially fast instead of exponentially slowly by constantly polling peers for new txs instead of only pushing a tx when we haven't heard of it before.

@joshua-kim joshua-kim added the bug Something isn't working label Jul 5, 2023
@joshua-kim
Copy link
Contributor Author

PR - #266

@joshua-kim joshua-kim linked a pull request Jul 5, 2023 that will close this issue
@joshua-kim joshua-kim self-assigned this Jul 5, 2023
@joshua-kim
Copy link
Contributor Author

Merged in #318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant