Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiplier to NativeTokenDestination #187

Closed
geoff-vball opened this issue Dec 8, 2023 · 0 comments · Fixed by #291
Closed

Add multiplier to NativeTokenDestination #187

geoff-vball opened this issue Dec 8, 2023 · 0 comments · Fixed by #291
Assignees
Labels
enhancement New feature or request

Comments

@geoff-vball
Copy link
Contributor

geoff-vball commented Dec 8, 2023

Context and scope
Some ERC20 contracts have decimals of something other than 18. Currently, sending 1 full token from an ERC20 contract with 24 decimals, will result in 10^6 full tokens being minted on the destination. We should make this configurable.

Discussion and alternatives
We decided that this should be handled on the destination chain only, as the source chain does not need to know the implementation specifics of the destination, and with this implementation, we can unify the interfaces among all the different token bridge contracts.

Open questions

@geoff-vball geoff-vball added the enhancement New feature or request label Dec 8, 2023
@geoff-vball geoff-vball self-assigned this Jan 30, 2024
@geoff-vball geoff-vball changed the title Add multiplier to ERC20TokenSource Add multiplier to NativeTokenDestination Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
1 participant