Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package from "client" #38

Closed
taion opened this issue Jul 18, 2018 · 3 comments
Closed

Rename package from "client" #38

taion opened this issue Jul 18, 2018 · 3 comments

Comments

@taion
Copy link
Contributor

taion commented Jul 18, 2018

It's a little confusing that the package is just client. This seems potentially prone to causing name collisions, and also hurts readability of code using this library.

It seems like it would be better if the import instead looked like e.g.:

from avalara import AvataxClient
@afreepenguin
Copy link

This was merged... should be in the docs under whatever version it was merged in for. Docs are a bit confusing given that.

@taion taion closed this as completed Jan 20, 2020
@afreepenguin
Copy link

Should leave the issue open until the docs are updated?

@taion
Copy link
Contributor Author

taion commented Jan 20, 2020

@afreepenguin I figured it would be less confusing to close this out given that #85 is open as well. I opened #86 to fix the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants