Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a configure option to enable/disable the tests #44

Closed
tgurr opened this issue Feb 13, 2018 · 4 comments · Fixed by #47
Closed

Add a configure option to enable/disable the tests #44

tgurr opened this issue Feb 13, 2018 · 4 comments · Fixed by #47

Comments

@tgurr
Copy link

tgurr commented Feb 13, 2018

Currently there doesn't seem to be a way to disable the tests, this causes a build dependency on check and pkg-config even when not planning to run any tests.

@agoode
Copy link
Contributor

agoode commented Feb 13, 2018

There is only a build dependency on pkg-config. check is only used if present.

Are you concerned about the pkg-config dependency?

@tgurr
Copy link
Author

tgurr commented Feb 13, 2018

Not only, actually about the unconditional usage of the pkg-config check for check. Such automagic stuff causes problem for source-based distributions where we need to be able to disable certain stuff even if the packages might be available/installed locally.

@agoode
Copy link
Contributor

agoode commented Feb 13, 2018

So it sounds like the solution is to add the proper --with-check/--without-check options, correct?

https://autotools.io/autoconf/arguments.html

@tgurr
Copy link
Author

tgurr commented Feb 13, 2018

Either that or --enable-tests/--disable-tests like quite a few other packages already do to make the tests and it's dependencies (de-)selectable via configure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants