Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when watch mode ignores changed Babel options #1703

Closed
novemberborn opened this issue Feb 12, 2018 · 4 comments
Closed

Warn when watch mode ignores changed Babel options #1703

novemberborn opened this issue Feb 12, 2018 · 4 comments

Comments

@novemberborn
Copy link
Member

As per #1702, we can't safely reload Babel options in watch mode. We can, however, try and detect if the Babel options have changed between runs. A warning should be printed so users are aware that an older Babel configuration was applied.

This is blocked on cleaning up the reporter code.

@novemberborn novemberborn added enhancement new functionality scope:babel blocked waiting on something else to be resolved first scope:watch-mode scope:reporters labels Feb 12, 2018
@sindresorhus
Copy link
Member

This is blocked on cleaning up the reporter code.

Is it still blocked on this. Can you link to the PR/issue that blocks it?

A warning should be printed so users are aware that an older Babel configuration was applied.

I think it would be better to exit watch mode in that case.

@novemberborn
Copy link
Member Author

Can you link to the PR/issue that blocks it?

I think I closed my own PR due to inactivity 😄

A warning should be printed so users are aware that an older Babel configuration was applied.

I think it would be better to exit watch mode in that case.

Yes, though is it even worth trying to figure out if the Babel options (and / or installed plugins) changed?

@sindresorhus
Copy link
Member

Yes, though is it even worth trying to figure out if the Babel options (and / or installed plugins) changed?

It might prevent some weird staleness issues. We don't need to detect what changed, only that something changed in the Babel-related stuff.

@novemberborn novemberborn removed the blocked waiting on something else to be resolved first label May 12, 2019
@novemberborn novemberborn added this to the v3 milestone Dec 21, 2019
@novemberborn
Copy link
Member Author

We're removing Babel from AVA itself. I don't think it's feasible to have change detection across different packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants