add max-asserts rule (fixes #6) #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
added a commit
that referenced
this pull request
Feb 28, 2016
add max-asserts rule (fixes #6)
|
Omg. Can't believe how fast those rules got done. Thank you so much @jfmengels! 🍻 Would you be interested in becoming a maintainer on this repo? No commitment required, just some credit in the readme.
|
|
Would love to! It would be the first repo I'm a maintainer of too :) I'll probably look at implementing other rules and proposing other ones (I think there are a lot of rules that can be made for in-editor purposes, like #26). Thanks for the amazing cooperation on all these PRs :) |
No, thank you. |
|
Damn @jfmengels is spitting fire! Super cool job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add max-asserts rule (fixes #6) :)
Last one of the rules implemented in #11 :)