Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-invalid-modifier-chain rule #309

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

KinectTheUnknown
Copy link

@KinectTheUnknown KinectTheUnknown commented Jul 29, 2020

No Invalid Modifier Chain

Fixes #186

Description

Disallows invalid combinations, order, and name of test/hook modifiers

Progress:

  • Detect invalid modifiers
    • Name
    • Order
    • Combination
  • More detailed errors
    • Conflicting modifiers
    • Order
  • Provide possible options to fix invalid modifiers
    • Mispellings
    • Order
    • Combinations
  • Configurable Options
    • Whitelist modifier names from being flagged Too complicated to implement at this time
  • Properly deprecate rules
    (note: Properly deprecated rules aren't supported by package tests)
    • no-duplicate-modifiers
    • no-unknown-modifiers

References:

Ava Test Modifier Tree
🦄


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


@novemberborn
Copy link
Member

Impressive start @KinectTheUnknown!

What kind of feedback are you looking for at this stage?

@KinectTheUnknown
Copy link
Author

Impressive start @KinectTheUnknown!

What kind of feedback are you looking for at this stage?

I just wanted to make sure that I'm on the right path as far as the goals and features of this rule and anything else that this rule should cover.

Right now, I'm making several changes to make error messages more specific so I can implement suggestions/fixes.

@novemberborn
Copy link
Member

I just wanted to make sure that I'm on the right path as far as the goals and features of this rule and anything else that this rule should cover.

Yea I think so!

Base automatically changed from master to main January 23, 2021 07:39
@sindresorhus
Copy link
Member

@KinectTheUnknown Still interested in finishing this?

@KinectTheUnknown
Copy link
Author

@KinectTheUnknown Still interested in finishing this?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restrict modifier chaining
3 participants