Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js version for Travis #89

Merged
merged 1 commit into from
Apr 27, 2016
Merged

Update Node.js version for Travis #89

merged 1 commit into from
Apr 27, 2016

Conversation

jfmengels
Copy link
Contributor

Update Node.js version for Travis

@jfmengels
Copy link
Contributor Author

Not that surprising, but it works on v6, yay :)

@ntwb
Copy link

ntwb commented Apr 27, 2016

Should this change 5 to 6 rather than just adding 6?

It is really just a major semver version bump than a new release branch IMHO.

See also: NodeJS as part of 6.0.0 have renamed stable to current in nodejs/node/pull/6318

@sindresorhus
Copy link
Member

Yes, let's drop testing on Node.js 5. We're only interested in testing on current and LTS releases.

Node.js v5 will continue to be supported for the next two months in order to give developers currently using v5 time to transition to Node.js v6. - https://nodejs.org/en/blog/release/v6.0.0/

@sindresorhus sindresorhus merged commit 07181f4 into master Apr 27, 2016
@sindresorhus sindresorhus deleted the update-node-6 branch April 27, 2016 07:36
@novemberborn
Copy link
Member

@sindresorhus while I doubt there'd be regressions that affect just v5, it seems sensible to keep testing until official support is withdrawn. Especially in the first few weeks when people won't necessarily have upgraded.

It is really just a major semver version bump than a new release branch IMHO.

@ntwb it's a major bump because of the breaking changes, which weren't previously in v5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants