Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: change references to Stable to Current #6318

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
8 participants
@MylesBorins
Copy link
Member

commented Apr 21, 2016

Checklist
Notes

With v6 we plan to rename the Stable release line to Current.
This commit updates all references to Stable in the codebase. It will
have to land along side updates to other repos within the org.

ref: nodejs/nodejs.org#669

@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 21, 2016

LGTM

@MylesBorins

This comment has been minimized.

Copy link
Member Author

commented Apr 21, 2016

/cc @nodejs/ctc

@evanlucas

This comment has been minimized.

Copy link
Member

commented Apr 21, 2016

I think changelog-maker will need an update too if I am remembering correctly

@MylesBorins

This comment has been minimized.

Copy link
Member Author

commented Apr 21, 2016

From my comment in nodejs/nodejs.org#669

We will also have to update the site, I think it might make sense for @fhemberger to handle that or at least someone more familiar with the code base as the word "stable" is used not only in the copy, but in css selectors and hard coded within the tests. That being said I think we should get 100% sign off before that work is done.

As far as I can tell there is nothing that needs to be updated in /download, but perhaps someone from @nodejs/build can verify that for me.

We will also have to update the copy in https://github.com/nodejs/lts

Turns out there is only a single reference to stable, but we'll need to also update the graphic (do you know where that lives @mikeal?). If I can get a copy of a psd or illustrator file I can update that

Those are just the references I knew off the top of my head, I'll do a more in depth search after we get sign off.

edit: I'm making a checklist in the top comment. Other collaborators please feel free to edit my comment and add more to the list

@MylesBorins

This comment has been minimized.

Copy link
Member Author

commented Apr 21, 2016

@evanlucas afaik changelog maker is agnostic to release lines. The title of the changelog is always made manually afaik

@evanlucas

This comment has been minimized.

Copy link
Member

commented Apr 21, 2016

@MylesBorins

This comment has been minimized.

Copy link
Member Author

commented Apr 21, 2016

PR has come in at a first pass to updating the website nodejs/nodejs.org#672

@MylesBorins MylesBorins added this to the 6.0.0 milestone Apr 21, 2016

@fhemberger

This comment has been minimized.

Copy link
Member

commented Apr 21, 2016

PR for changelog-maker: nodejs/changelog-maker#38

@Fishrock123

This comment has been minimized.

Copy link
Member

commented Apr 23, 2016

With v6 we plan to rename the Stable release line to Current.

We do?

@Fishrock123 Fishrock123 modified the milestone: 6.0.0 Apr 23, 2016

@MylesBorins

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2016

@Fishrock123

This comment has been minimized.

Copy link
Member

commented Apr 23, 2016

I have voiced my concerns at nodejs/nodejs.org#669 (comment)

We need to make sure we give the large changes more time and not just cram them in before breaking releases...

Speaking of which, this doesn't actually have to be done in a breaking release at all. I'd rather everyone be good with it and change it afterwards than not.

@evanlucas

This comment has been minimized.

Copy link
Member

commented Apr 24, 2016

This probably needs CTC approval?

@Fishrock123

This comment has been minimized.

Copy link
Member

commented Apr 24, 2016

@evanlucas at the very least, I think.

@Fishrock123

This comment has been minimized.

Copy link
Member

commented Apr 24, 2016

Thinking about this more in nodejs/nodejs.org#669 (comment)

Ok. I definitely think we should really take this past evangelism/marketing. I'm afraid a shift without warning may rub off on downstream customers badly and people may be increasingly hesitant about things if we do it with no prior publicly communicated indicator.

@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 24, 2016

Getting ctc review and encouraging input from the collaborators is exactly why this PR was opened :-)

@Trott

This comment has been minimized.

Copy link
Member

commented Apr 24, 2016

@Fishrock123 wrote:

I definitely think we should really take this past evangelism/marketing.

@nodejs/evangelism @nodejs/website

@mikeal

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2016

CTC should weigh in but it would be good to have the website change ready
for the v6 release.

On Saturday, April 23, 2016, Rich Trott notifications@github.com wrote:

@Fishrock123 https://github.com/Fishrock123 wrote:

I definitely think we should really take this past evangelism/marketing.

@nodejs/evangelism https://github.com/orgs/nodejs/teams/evangelism
@nodejs/website https://github.com/orgs/nodejs/teams/website


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6318 (comment)

@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 25, 2016

Need to know today if we're going to use the new naming for v6

@ChALkeR

View changes

doc/releases.md Outdated
@@ -187,7 +187,7 @@ Jenkins collects the artifacts from the builds, allowing you to download and ins

Once you have produced builds that you're happy with, create a new tag. By waiting until this stage to create tags, you can discard a proposed release if something goes wrong or additional commits are required. Once you have created a tag and pushed it to GitHub, you ***should not*** delete and re-tag. If you make a mistake after tagging then you'll have to version-bump and start again and count that tag/version as lost.

Tag summaries have a predictable format, look at a recent tag to see, `git tag -v v5.3.0`. The message should look something like `2015-12-16 Node.js v5.3.0 (Stable) Release`.
Tag summaries have a predictable format, look at a recent tag to see, `git tag -v v6.0.0`. The message should look something like `2016-4-26 Node.js v6.0.0 (Current) Release`.

This comment has been minimized.

Copy link
@ChALkeR

ChALkeR Apr 25, 2016

Member

2016-04-26 (note the 0).

@ChALkeR

This comment has been minimized.

Copy link
Member

commented Apr 25, 2016

This does LGTM (with a nit).

The only concern that I have here is that we would actually have LTS, Current, Maintenance, and Stable, at least in the changelog. We should make sure that the renaming is clear and that people can look up what did Stable mean. Perhaps we could add a line that Current was previsously named as Stable to the Readme?

@evanlucas

This comment has been minimized.

Copy link
Member

commented Apr 25, 2016

LGTM with @ChALkeR's nit addressed

@fhemberger

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

PR for download page redirect: nodejs/build#399

@thealphanerd Can you please update the original post?

@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

@nodejs/ctc ... I need a final Go / No Go on making this change in this release. @Fishrock123 has voiced an objection. Need to know what to use for this release.

@fhemberger

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

@jasnell Website has already been updated: nodejs/nodejs.org#672 (comment)

@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

Ok... that settles it then lol. @thealphanerd can you make sure this PR is up to date and get it landed?

doc: change references to Stable to Current
With v6 we plan to rename the Stable release line to Current.
This commit updates all references to Stable in the codebase. It will
have to land along side updates to other repos within the org.

ref: nodejs/nodejs.org#669

@MylesBorins MylesBorins force-pushed the MylesBorins:stable-to-current branch to d6a5f98 Apr 26, 2016

jasnell added a commit that referenced this pull request Apr 26, 2016

doc: change references to Stable to Current
With v6 we plan to rename the Stable release line to Current.
This commit updates all references to Stable in the codebase. It will
have to land along side updates to other repos within the org.

Refs: nodejs/nodejs.org#669
PR-URL: #6318
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

Landed in 29a6c7c

@jasnell jasnell closed this Apr 26, 2016

jasnell added a commit that referenced this pull request Apr 26, 2016

doc: change references to Stable to Current
With v6 we plan to rename the Stable release line to Current.
This commit updates all references to Stable in the codebase. It will
have to land along side updates to other repos within the org.

Refs: nodejs/nodejs.org#669
PR-URL: #6318
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

jbergstroem added a commit to nodejs/build that referenced this pull request May 1, 2016

www: redirect `stable` `current`
With the change of release names from 'Stable' to 'Current'
(introduced with Node.js v6), the old download page
needs to be redirected.

PR-URL: #399
Refs: nodejs/node#6318
Refs: nodejs/nodejs.org#672
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

@MylesBorins MylesBorins deleted the MylesBorins:stable-to-current branch May 12, 2016

MylesBorins added a commit that referenced this pull request Jun 1, 2016

doc: change references to Stable to Current
With v6 we plan to rename the Stable release line to Current.
This commit updates all references to Stable in the codebase. It will
have to land along side updates to other repos within the org.

Refs: nodejs/nodejs.org#669
PR-URL: #6318
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

@MylesBorins MylesBorins referenced this pull request Jun 24, 2016

Merged

v4.4.7 proposal #7395

MylesBorins added a commit that referenced this pull request Jun 24, 2016

doc: change references to Stable to Current
With v6 we plan to rename the Stable release line to Current.
This commit updates all references to Stable in the codebase. It will
have to land along side updates to other repos within the org.

Refs: nodejs/nodejs.org#669
PR-URL: #6318
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

MylesBorins added a commit that referenced this pull request Jun 24, 2016

doc: change references to Stable to Current
With v6 we plan to rename the Stable release line to Current.
This commit updates all references to Stable in the codebase. It will
have to land along side updates to other repos within the org.

Refs: nodejs/nodejs.org#669
PR-URL: #6318
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.