Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The func onRetry should not be called when retryIf returns false #20

Closed
pallavJha opened this issue Oct 6, 2019 · 0 comments · Fixed by #21
Closed

The func onRetry should not be called when retryIf returns false #20

pallavJha opened this issue Oct 6, 2019 · 0 comments · Fixed by #21

Comments

@pallavJha
Copy link

retry-go/retry.go

Line 100 in 101acd3

config.onRetry(n, err)

The func onRetry is called before checking if the retryableFunc should be retried. The func retryIf, called after onRetry, tells whether the retry should be performed or not.

retryIf should be called before onRetry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

retryIf should be called before onRetry
1 participant
@pallavJha