Clean up tests

[charlierudolph]

Second try. See the individual commits for what is being done.

[coveralls]

Coverage increased (+0.37%) when pulling d3496c9 on charlierudolph:clean_up_tests into a82d1d1 on avdi:master.

[coveralls]

Coverage increased (+0.37%) when pulling 9e2872c on charlierudolph:clean_up_tests into a82d1d1 on avdi:master.

[sferik]

This looks much better. Thanks for breaking out all the changes into individual commits.

I’d like to see if @avdi has any feedback before I merge.

[avdi]

Overall this definitely seems like an improvement. Thanks for all the work, @charlierudolph!

[coveralls]

Coverage increased (+0.2%) when pulling af52315 on charlierudolph:clean_up_tests into a82d1d1 on avdi:master.

[charlierudolph]

Looking more at the code I think base_class_spec should be removed.
Setting the base_class is what is done by impersonate. It also tests singleton which has its own spec