Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete and improve lookup blocks #19

Closed
2 of 4 tasks
Flashing-Blinkenlights opened this issue Jul 14, 2022 · 1 comment
Closed
2 of 4 tasks

Complete and improve lookup blocks #19

Flashing-Blinkenlights opened this issue Jul 14, 2022 · 1 comment
Assignees
Labels
cleanup Tidying up code to improve usability documentation Improvements or additions to documentation in-progress We're working on it

Comments

@Flashing-Blinkenlights
Copy link
Collaborator

Flashing-Blinkenlights commented Jul 14, 2022

Feature branch: 5.1

The sets of blocks in lookup is fairly messy, with some blocks missing and a lot of repetition. Steps should be taken to clean up this information and tests made to make sure no blocks are overlooked.

  • Use set comprehensions for block variations
  • Eliminate redundancy where possibly
  • Highlight redundancies
  • If possible, cross-reference with client's assets
@Flashing-Blinkenlights Flashing-Blinkenlights added documentation Improvements or additions to documentation cleanup Tidying up code to improve usability in-progress We're working on it labels Jul 14, 2022
@Flashing-Blinkenlights
Copy link
Collaborator Author

Updated block lists, tidied up groups, adjusted and added tests to check for missing/incorrect blocks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Tidying up code to improve usability documentation Improvements or additions to documentation in-progress We're working on it
Projects
None yet
Development

No branches or pull requests

1 participant