Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Not auto-selecting highest quality if the preferred one doesn't exist #96

Closed
swolewizard opened this issue May 27, 2023 · 15 comments
Labels
bug Something isn't working

Comments

@swolewizard
Copy link

Is your feature request related to a problem? Please describe

Hey there! I'm loving your YouTube extension, but I have a small issue I'd like to address. Currently, if I select a quality that doesn't exist for the video I'm watching, the extension doesn't do anything. It would be awesome if it could automatically choose the next highest quality available. For example, if I set the extension to 1440p but the video's highest quality is 1080p, it should automatically select 1080p. Thanks for considering my suggestion!

Is it a change to the extension's functionality or to the pop-up settings page?

Extension's functionality

If the latter, please propose a new design on Figma or describe it as detailed as possible

No response

Additional context

No response

@swolewizard swolewizard added the enhancement New feature or request label May 27, 2023
@avi12
Copy link
Owner

avi12 commented May 27, 2023

That's how the extension should behave by default

} else if (getIsQualityLower(elQualities[0], window.ythdLastUserQualities[fpsStep])) {
const iQualityAvailable = qualitiesAvailable.findIndex(quality => quality > 0);
applyQuality(iQualityAvailable);
} else {

@avi12 avi12 added bug Something isn't working and removed enhancement New feature or request labels May 27, 2023
@avi12
Copy link
Owner

avi12 commented May 27, 2023

What browser are you on? Are you using the latest version, 1.7.10?

@avi12 avi12 changed the title [Feature request] Automatic Selection of Next Highest Quality [Bug] Not auto-selecting highest quality if the preferred one doesn't exist May 27, 2023
@swolewizard
Copy link
Author

I'm using Chrome
Using version: 1.7.10

When I set my preferred quality to 1440p or above and open a video without those quality settings, the extension does nothing
Like this:
First

But if I change the quality on the extension with the video currently open, It'll then automatically choose the next highest quality available
Like this:
Second

@avi12
Copy link
Owner

avi12 commented May 27, 2023

That's peculiar
Please click the settings button and take a screenshot

@swolewizard
Copy link
Author

Which settings did you want

@avi12
Copy link
Owner

avi12 commented May 27, 2023

I need to see the settings menu

@swolewizard
Copy link
Author

Not sure which settings menu you're referring to, I'll send all I can think of

setting1
setting2
setting3

@avi12
Copy link
Owner

avi12 commented May 27, 2023

Thanks, I only needed the 3rd screenshot :)
That's very weird indeed
So if I understand correctly, when you first load the video, the video quality stays on Auto?

@swolewizard
Copy link
Author

That's correct

@avi12
Copy link
Owner

avi12 commented May 27, 2023

Can you try to sideload the ext locally?

@swolewizard
Copy link
Author

swolewizard commented May 27, 2023

Unless the quality I've selected in the extension exists, then it correctly switches to 1440p for example

@swolewizard
Copy link
Author

Can you try to sideload the ext locally?

no idea how todo this even reading all that

@avi12
Copy link
Owner

avi12 commented May 27, 2023

Can you contact me via Discord so I can guide you on how? avi12#4269

@swolewizard
Copy link
Author

Reached out to @avi12 on Discord and found out that the problem I was experiencing was due to a conflicting extension called Looper for YouTube. Removing this extension resolved the issue. Currently, I've kept Looper for YouTube disabled so I can continue using the extension.
I was informed that @avi12 will investigate and work on a hotfix to ensure compatibility between the two extensions. Really looking forward to the hotfix and appreciate your assistance!

@avi12
Copy link
Owner

avi12 commented May 27, 2023

Sadly the issue isn't easily fixable and the possible solution is to awkwardly keep changing the quality until one extension "gives up"
Better contact Looper's developer to ask him make the auto HD functionality toggleable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants