Skip to content

Commit

Permalink
Credo powered improvements for monei (#47)
Browse files Browse the repository at this point in the history 
* Refactored code as suggested by credo

Closes #27

* Grouped tests using describe

* Better test descriptions

Removed the pipes and spaces

* Renamed ia CamelCase var.

`paymentId` -> `payment_id`

* Renamed missed CamelCase var, improves CC coverage

* I had missed a few `paymentId`s.
* Since #48 is merged, we can use full_name(). Coverage increased for
free :)

* Ran the elixir 1.6 formatter on Monei

* Fixed unstore test description
* Example cards will expire in 82 yrs :P
  • Loading branch information
@oyeb @pkrawat1
oyeb authored and pkrawat1 committed Dec 28, 2017
1 parent bed2509 commit 18db1db
Show file tree
Hide file tree
Showing 2 changed files with 259 additions and 184 deletions.
Loading

0 comments on commit 18db1db

Please sign in to comment.