Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "parameter_pattern_matching" issue in lib/gringotts/gateways/monei.ex #27

Closed
pkrawat1 opened this issue Dec 21, 2017 · 0 comments
Closed

Fix "parameter_pattern_matching" issue in lib/gringotts/gateways/monei.ex #27

pkrawat1 opened this issue Dec 21, 2017 · 0 comments
Assignees
@oyeb
Labels
codeclimate codestyle effort1: easy(hours) hotlist: community-help severity: low

Comments

@pkrawat1
Copy link
Member

File has the variable name before the pattern while most of the files have the variable name after the pattern when naming parameter pattern matches

https://codeclimate.com/github/aviabird/gringotts/lib/gringotts/gateways/monei.ex#issue_5a3a55fffc0835000100004b
@pkrawat1 pkrawat1 added this to the Release 1.5.0 milestone Dec 21, 2017
oyeb added a commit that referenced this issue Dec 24, 2017
@oyeb
Refactored code as suggested by credo
e0c9e1d 
Closes #27
oyeb added a commit that referenced this issue Dec 26, 2017
@oyeb
Refactored code as suggested by credo
bfaefac 
Closes #27
pkrawat1 pushed a commit that referenced this issue Dec 27, 2017
@oyeb @pkrawat1
Credo powered improvements for monei (#47)
4306a89 
* Refactored code as suggested by credo

Closes #27

* Grouped tests using describe

* Better test descriptions

Removed the pipes and spaces

* Renamed ia CamelCase var.

`paymentId` -> `payment_id`

* Renamed missed CamelCase var, improves CC coverage

* I had missed a few `paymentId`s.
* Since #48 is merged, we can use full_name(). Coverage increased for
free :)

* Ran the elixir 1.6 formatter on Monei

* Fixed unstore test description
* Example cards will expire in 82 yrs :P
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oyeb oyeb

Labels
codeclimate codestyle effort1: easy(hours) hotlist: community-help severity: low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pkrawat1 @oyeb